-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Overhaul Part 1 - Octokit Library #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a new interface and class to handle checking for updates on GitHub (does not install yet) - Added Octokit library
- Modified global variables to avoid implicit definitions - Added update controller to global variables - Updated OctoKit NuGet library to latest version - Removing update provider classes and interface in favor of single defined class with multiple event argument classes
- Renamed the Update_Gui form to UpdateAvailableForm, and relocated it in the Forms namespace/folder. - Overhauled form and logic for updating. Most update check/download logic is handled outside of the form (in UpdateUtil or WinNUT.vb). Form generally handles events and small visual changes. - Removed most update-related strings from WinNUT. Besides a few notification strings, most will be found in the UpdateAvailableForm. Requires translators. - Removed AutoUpdate setting. WinNUT doesn't have the functionality to automatically check for updates during operation - it only does this when first starting. - Applied this change to Pref_Gui and simplified some logic.
Corrected references, and fixed a String.Format call.
- Upgrade Common project file to PackageReferences type to try to fix the Octokit library error. - Disable ClickOnce publishing again - Fix Logger writing to a number '3' folder in DEBUG mode
3 tasks
3 tasks
3 tasks
3 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #133.