Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Overhaul Part 1 - Octokit Library #176

Merged
merged 9 commits into from
Aug 10, 2024

Conversation

gbakeman
Copy link
Contributor

@gbakeman gbakeman commented Aug 10, 2024

  • Moved most update login to a separate class in the Common library. Relies on Octokit library over custom JSON parsing code.
  • Added some event handlers to WinNUT.vb to handle update checks and launch the update form when necessary
  • Overhauled Update_Gui form, renaming it to UpdateAvailableForm. Form is built in the Designer, with minimal logic in the code-behind.

Related to #133.

- Created a new interface and class to handle checking for updates on GitHub (does not install yet)
- Added Octokit library
- Modified global variables to avoid implicit definitions
- Added update controller to global variables
- Updated OctoKit NuGet library to latest version
- Removing update provider classes and interface in favor of single defined class with multiple event argument classes
- Renamed the Update_Gui form to UpdateAvailableForm, and relocated it in the Forms namespace/folder.
- Overhauled form and logic for updating. Most update check/download logic is handled outside of the form (in UpdateUtil or WinNUT.vb). Form generally handles events and small visual changes.
- Removed most update-related strings from WinNUT. Besides a few notification strings, most will be found in the UpdateAvailableForm. Requires translators.
- Removed AutoUpdate setting. WinNUT doesn't have the functionality to automatically check for updates during operation - it only does this when first starting.
- Applied this change to Pref_Gui and simplified some logic.
@gbakeman gbakeman added the enhancement New feature or request label Aug 10, 2024
@gbakeman gbakeman added this to the 2.3 Stable Release milestone Aug 10, 2024
Corrected references, and fixed a String.Format call.
- Upgrade Common project file to PackageReferences type to try to fix the Octokit library error.
- Disable ClickOnce publishing again
- Fix Logger writing to a number '3' folder in DEBUG mode
@gbakeman gbakeman linked an issue Aug 10, 2024 that may be closed by this pull request
3 tasks
@gbakeman gbakeman removed a link to an issue Aug 10, 2024
3 tasks
@gbakeman gbakeman merged commit 7704c1f into dev-2.3 Aug 10, 2024
1 check passed
@gbakeman gbakeman deleted the 133-modify-update-routines branch August 10, 2024 20:55
@gbakeman gbakeman linked an issue Aug 10, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate GitHub library for updating
1 participant