Skip to content

Commit

Permalink
Deprecate url-loader and use native webpack file loading instead. Upg…
Browse files Browse the repository at this point in the history
…rade webpack loaders.
  • Loading branch information
nukeop committed Jan 30, 2025
1 parent 0cba60e commit d3fd11b
Show file tree
Hide file tree
Showing 8 changed files with 49 additions and 87 deletions.
112 changes: 38 additions & 74 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import { ArtistTopTrack } from '@nuclear/core/src/plugins/plugins.types';
import { TextCell } from '@nuclear/ui/lib/components/GridTrackTable/Cells/TextCell';
import { Track } from '@nuclear/ui/lib/types';

import trackRowStyles from '../../TrackRow/styles.scss';
import TrackTableContainer from '../../../containers/TrackTableContainer';
import * as trackRowStyles from '../../TrackRow/styles.scss';
import * as styles from './styles.scss';

type AddAllButtonProps = {
Expand Down
8 changes: 3 additions & 5 deletions packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,25 +104,23 @@
"cross-env": "^7.0.3",
"css-loader": "7.1.2",
"eslint": "^7.18.0",
"file-loader": "^6.2.0",
"html-webpack-plugin": "5.6.3",
"i18next-json-sync": "^2.3.1",
"identity-obj-proxy": "^3.0.0",
"jest": "^27.5.1",
"megalodon": "^3.6.1",
"mock-require": "^3.0.3",
"react-beautiful-dnd-test-utils": "^4.1.0",
"react-hot-loader": "^4.13.1",
"react-hot-loader": "4.13.1",
"redux-mock-store": "^1.5.4",
"sass": "1.83.4",
"sass-loader": "16.0.4",
"style-loader": "4.0.0",
"svg-inline-loader": "^0.8.2",
"svg-inline-loader": "0.8.2",
"ts-jest": "^27.1.3",
"ts-loader": "^8.0.3",
"ts-loader": "9.5.2",
"ts-node": "^10.7.0",
"typescript": "^4.2.4",
"url-loader": "^4.1.1",
"utf-8-validate": "^5.0.2",
"webpack": "5.97.1",
"webpack-cli": "6.0.1",
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/app/webpack.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -222,12 +222,12 @@ module.exports = (env) => {
},
{
test: /\.(png|jpg|gif)$/,
loader: 'url-loader',
type: 'asset/resource',
include: [RESOURCES_DIR, APP_DIR, UI_DIR, VENDOR_DIR]
},
{
test: /\.(ttf|eot|woff|woff2|svg)$/,
loader: 'url-loader',
type: 'asset/resource',
include: [UI_DIR, APP_DIR, VENDOR_DIR]
},
{
Expand Down
2 changes: 1 addition & 1 deletion packages/main/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"node-loader": "^0.6.0",
"shx": "^0.3.3",
"ts-jest": "^27.1.3",
"ts-loader": "^9.5.1",
"ts-loader": "9.5.2",
"ts-node": "^10.7.0",
"type-fest": "^0.8.1",
"typescript": "^4.2.4",
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/.storybook/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ module.exports = {
},
{
test: /\.(ttf|eot|woff|woff2|svg)$/,
loader: 'url-loader',
type: 'asset/resource',
include: [
path.resolve(__dirname, '../resources')
]
},
{
test: /\.(png|jpg|gif)$/,
loader: 'url-loader',
type: 'asset/resource',
include: path.resolve(__dirname, '../resources')
}
]
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,12 @@
"identity-obj-proxy": "^3.0.0",
"ignore-styles": "^5.0.1",
"jest": "^27.5.1",
"react-hot-loader": "^4.12",
"react-hot-loader": "4.13.1",
"sass": "1.83.4",
"sass-loader": "16.0.4",
"style-loader": "4.0.0",
"ts-jest": "^27.1.3",
"ts-loader": "^8.0.3",
"ts-loader": "9.5.2",
"ts-node": "^10.7.0",
"typescript": "^4.2.4"
},
Expand Down

0 comments on commit d3fd11b

Please sign in to comment.