Skip to content

feat(core)!: drop support for node versions prior to 20.19.0 #30818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(core)!: drop support for node versions prior to 20.19.0 #30818

wants to merge 3 commits into from

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Apr 22, 2025 •
edited
Loading

BREAKING CHANGE: We are updating our minimum node version to 20.19.0 which drops support for all prior versions.

@ndcunningham ndcunningham self-assigned this Apr 22, 2025
@ndcunningham ndcunningham requested a review from a team as a code owner April 22, 2025 19:20
@ndcunningham ndcunningham requested a review from AgentEnder April 22, 2025 19:20
@vercel Vercel
Copy link

vercel bot commented Apr 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 25, 2025 6:51pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 1d10310.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-ci ❌ Failed 56m 12s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-25 19:07:04 UTC

JamesHenry
JamesHenry requested changes Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See slack thread

@ndcunningham ndcunningham force-pushed the feat/upgrade-to-node-20 branch from 5a0dd8e to a84176c Compare April 22, 2025 20:15
@ndcunningham ndcunningham requested review from a team as code owners April 22, 2025 20:15
@ndcunningham ndcunningham changed the title feat(core): Update base Node version to 20 feat(core)!: drop support for node versions prior to 20.19.0 Apr 22, 2025
@ndcunningham ndcunningham requested a review from JamesHenry April 22, 2025 20:20
@ndcunningham ndcunningham force-pushed the feat/upgrade-to-node-20 branch from a84176c to b861e7d Compare April 22, 2025 20:45
@github-actions GitHub Actions
Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-30818-a84176c my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-30818-a84176c
Release details 📑
Published version 0.0.0-pr-30818-a84176c
Triggered by @ndcunningham
Branch feat/upgrade-to-node-20
Commit a84176c
Workflow run 14604007199

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@github-actions GitHub Actions
Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@0.0.0-pr-30818-b861e7d my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-30818-b861e7d
Release details 📑
Published version 0.0.0-pr-30818-b861e7d
Triggered by @ndcunningham
Branch feat/upgrade-to-node-20
Commit b861e7d
Workflow run 14605127935

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@ndcunningham ndcunningham force-pushed the feat/upgrade-to-node-20 branch from c18ae70 to 85646cb Compare April 23, 2025 17:19
@ndcunningham ndcunningham force-pushed the feat/upgrade-to-node-20 branch from 85646cb to 116a310 Compare April 23, 2025 17:47
@beaussan
Copy link
Contributor

Hey there 👋

I suspect the node 20.19 was picked for the require(esm) support

If that's the case, you may want to support only node 22.12 and up instead of 22.x

Since it's not enabled under 22.12 by default, you would have node version in your support range that don't support require(esm)

See release notes for 22.12 https://nodejs.org/en/blog/release/v22.12.0

@ndcunningham ndcunningham force-pushed the feat/upgrade-to-node-20 branch from 116a310 to 102abca Compare April 23, 2025 18:06
@ndcunningham ndcunningham force-pushed the feat/upgrade-to-node-20 branch from 102abca to 2988e0b Compare April 23, 2025 18:51
@ndcunningham ndcunningham force-pushed the feat/upgrade-to-node-20 branch from 2988e0b to 0a73e56 Compare April 24, 2025 17:37
@ndcunningham ndcunningham added scope: core core nx functionality PR status: breaking-changes PR contains breaking changes labels Apr 24, 2025
@ndcunningham
feat(core)!: drop support for node versions prior to 20.19.0
1cebd3d 
Remove engines entry for napi-rs

BREAKING CHANGE: Node versions earlier to 20.19.0

docs(nx-dev): Fix node support matrix

(cherry picked from commit 742b371)
@ndcunningham ndcunningham force-pushed the feat/upgrade-to-node-20 branch from 0a73e56 to 1cebd3d Compare April 25, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaysoo jaysoo jaysoo left review comments

@JamesHenry JamesHenry JamesHenry approved these changes

@AgentEnder AgentEnder Awaiting requested review from AgentEnder AgentEnder is a code owner automatically assigned from nrwl/nx-pipelines-reviewers

@isaacplmann isaacplmann Awaiting requested review from isaacplmann isaacplmann was automatically assigned from nrwl/nx-docs-reviewers

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz FrozenPandaz is a code owner

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ndcunningham ndcunningham

Labels
PR status: breaking-changes PR contains breaking changes scope: core core nx functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndcunningham @beaussan @jaysoo @JamesHenry