feat(dashboard): Digest liquid helper and popover handler #7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow arbitrary variables on the payload namespace after adding at least one variable in a previous control value.
…into pills-for-all-inputs
scopsy
commented
Jan 6, 2025
| * {{ users | digest: 2, "name" }} => For array of {name: string} | ||
| * {{ users | digest: 2, "profile.name", "•" }} => "John • Josh and 3 others" | ||
| */ | ||
| export function digest(array: unknown, maxNames = 2, keyPath?: string, separator = ', '): string { |
There was a problem hiding this comment.
Not sure if that's the best name 🤔
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scopsy
commented
Jan 17, 2025
| filters: Filters[]; | ||
| }; | ||
|
|
||
| export function useSuggestedFilters(variableName: string, currentFilters: FilterWithParam[]): SuggestionGroup[] { |
There was a problem hiding this comment.
These provide filter suggestion based on common variable names, patterns of data
scopsy
commented
Jan 17, 2025
| this.templateEngine.registerFilter('json', (value, spaces) => | ||
| stringifyDataStructureWithSingleQuotes(value, spaces) | ||
| ); | ||
| this.templateEngine.registerFilter('digest', digest); |
There was a problem hiding this comment.
@SokratisVidros any name suggestions?
scopsy
commented
Jan 17, 2025
Comment on lines
+126
to
+129
| const parserEngine = new Liquid(LIQUID_CONFIG); | ||
|
|
||
| // Register digest filter for validation of digest transformers | ||
| parserEngine.registerFilter('digest', () => ''); |
There was a problem hiding this comment.
Currently we have 2 version of liquid one in the framework and one in the API, didn't do it in this PR but worth considering consolidating them somehow or exporting from the framework the parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer