Add missing external_user_id option to DeviceResolver (#110)

* Add missing `external_user_id` option to DeviceResolver * Add missing `external_user_id` option to DeviceResolver
norkunas · Jan 10, 2019 · 69f7654 · 69f7654
1 parent c5a5f59
commit 69f7654
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/Resolver/DeviceResolver.php b/src/Resolver/DeviceResolver.php
@@ -75,6 +75,8 @@ public function resolve(array $data)
             ->setAllowedTypes('lat', 'double')
             ->setDefined('country')
             ->setAllowedTypes('country', 'string')
+            ->setDefined('external_user_id')
+            ->setAllowedTypes('external_user_id', 'string')
             ->setDefault('app_id', $this->config->getApplicationId())
             ->setAllowedTypes('app_id', 'string');
 

diff --git a/tests/OneSignal/Tests/Resolver/DeviceResolverTest.php b/tests/OneSignal/Tests/Resolver/DeviceResolverTest.php
@@ -44,6 +44,7 @@ public function testResolveWithValidValues()
             'long' => 55.1684595,
             'lat' => 22.7624291,
             'country' => 'LT',
+            'external_user_id' => 'value',
             'app_id' => 'value',
         ];
 
@@ -109,6 +110,7 @@ public function wrongValueTypesProvider()
             [['country' => false]],
             [['app_id' => 666]],
             [['device_type' => 666]],
+            [['external_user_id' => 666]],
         ];
     }