feat: Prepare opendata_collector_module for release #161
Conversation
run_tests.sh
Outdated
There was a problem hiding this comment.
I didn't find where this file is currently used, so maybe it should be deleted?
There was a problem hiding this comment.
It probably was the main way to test the code before we switched to GitHub actions. You could check if there is anything in our Jenkins pipelines that use it. If not, I think we could delete it.
There was a problem hiding this comment.
didn't find this file mentioned anywhere, therefore deleted it.
There was a problem hiding this comment.
regarding changes in this file (and also related test and documentation changes): see #63
Ie. initially it was intended that the 'opendata_collector' MongoDB user is supposed to be created manually by admin.
To me it made sense to "normalize" this behavior and make things happen automatically like for other metrics modules.
There might be considerations against that (that i'm not aware of) - in that case i'll revert this part.
There was a problem hiding this comment.
I think in this case it would be better to keep the behavior so that the opendata_collector MongoDB user is not created automatically. The reason for it is that this module is likely not something most setups will install. It is meant to collect data from other Metrics instances, so it would be best if the default installation path didn't add anything specific to this module.
There was a problem hiding this comment.
got it, done.
fix type checking error bump vcrpy test requirement enable od-collector tests for github actions bump lib versions fix cron example fail under 60pct of coverage update run_tests.sh add opendata_collector role for mongo enable dependabot for opendata_collector_module refs: OPMONDEV-191
nortaljevgenikr
force-pushed
the
OPMONDEV-191-od-collector-updates
branch
from
a3558dd to
28ad56b
Compare
nortaljevgenikr
changed the title
There was a problem hiding this comment.
I think in this case it would be better to keep the behavior so that the opendata_collector MongoDB user is not created automatically. The reason for it is that this module is likely not something most setups will install. It is meant to collect data from other Metrics instances, so it would be best if the default installation path didn't add anything specific to this module.
run_tests.sh
Outdated
There was a problem hiding this comment.
It probably was the main way to test the code before we switched to GitHub actions. You could check if there is anything in our Jenkins pipelines that use it. If not, I think we could delete it.
|
for opendata_collector module:
bandit,detect-secrets,safety,pip-audittools - OKRefs: OPMONDEV-191