removed docker cleanup step

Signed-off-by: Elias Joseph <eljoseph@amd.com>
nod-ai · Feb 15, 2025 · 244f062 · 244f062
1 parent 06175a7
commit 244f062
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/.github/workflows/ci-sglang-benchmark.yml b/.github/workflows/ci-sglang-benchmark.yml
@@ -82,7 +82,9 @@ jobs:
 
       - name: Login to huggingface
         continue-on-error: true
-        run: huggingface-cli login --token ${{ secrets.HF_TOKEN }}
+        run: |
+          pip install -U "huggingface_hub[cli]"
+          huggingface-cli login --token ${{ secrets.HF_TOKEN }}
 
       - name: Run Shortfin Benchmark Tests
         run: |
@@ -192,10 +194,6 @@ jobs:
       - name: Stop sglang-server
         run: docker stop sglang-server || true # Stop container if it's running
 
-      # Deleting image after run due to large disk space requirement (83 GB)
-      - name: Cleanup SGLang Image
-        run: docker image rm lmsysorg/sglang:v0.3.5.post1-rocm620
-
   merge_and_upload_reports:
     name: "Merge and upload benchmark reports"
     needs: [benchmark_shortfin, benchmark_sglang]

diff --git a/app_tests/integration_tests/llm/sglang/conftest.py b/app_tests/integration_tests/llm/sglang/conftest.py
@@ -27,7 +27,6 @@
 
 
 def register_shortfin_backend(port):
-    print("------HERE------" + str(port))
     backend = sgl.Shortfin(
         chat_template=get_chat_template("llama-3-instruct"),
         base_url=f"http://localhost:{port}",