Merge pull request #371 from nimblehq/chore/369-update-deprecated-det…

…ekt-attrs-in-all-template [#369] Update deprecated Detekt attrs in all templates
nimblehq · Dec 20, 2022 · 602c3cf · 602c3cf
2 parents 89de3d1 + bf665f1
commit 602c3cf
Show file tree

Hide file tree

Showing 4 changed files with 100 additions and 96 deletions.
diff --git a/sample-compose/detekt-config.yml b/sample-compose/detekt-config.yml
@@ -70,7 +70,7 @@ complexity:
     threshold: 20
   LongParameterList:
     active: true
-    threshold: 5
+    functionThreshold: 5
     ignoreDefaultParameters: true
   MethodOverloading:
     active: false
@@ -127,7 +127,7 @@ exceptions:
   active: true
   ExceptionRaisedInUnexpectedLocation:
     active: false
-    methodNames: 'toString,hashCode,equals,finalize'
+    methodNames: [ 'toString', 'hashCode', 'equals', 'finalize' ]
   InstanceOfCheckForException:
     active: false
   NotImplementedDeclaration:
@@ -146,28 +146,28 @@ exceptions:
     active: false
   ThrowingExceptionsWithoutMessageOrCause:
     active: false
-    exceptions: 'IllegalArgumentException,IllegalStateException,IOException'
+    exceptions: [ 'IllegalArgumentException', 'IllegalStateException', 'IOException' ]
   ThrowingNewInstanceOfSameException:
     active: false
   TooGenericExceptionCaught:
     active: true
     exceptionNames:
-     - ArrayIndexOutOfBoundsException
-     - Error
-     - Exception
-     - IllegalMonitorStateException
-     - NullPointerException
-     - IndexOutOfBoundsException
-     - RuntimeException
-     - Throwable
+      - ArrayIndexOutOfBoundsException
+      - Error
+      - Exception
+      - IllegalMonitorStateException
+      - NullPointerException
+      - IndexOutOfBoundsException
+      - RuntimeException
+      - Throwable
   TooGenericExceptionThrown:
     active: true
     exceptionNames:
-     - Error
-     - Exception
-     - NullPointerException
-     - Throwable
-     - RuntimeException
+      - Error
+      - Exception
+      - NullPointerException
+      - Throwable
+      - RuntimeException
 
 naming:
   active: true
@@ -179,7 +179,7 @@ naming:
     enumEntryPattern: '^[A-Z$][a-zA-Z_$]*$'
   ForbiddenClassName:
     active: false
-    forbiddenName: ''
+    forbiddenName: [ '' ]
   FunctionMaxLength:
     active: false
     maximumFunctionNameLength: 30
@@ -188,13 +188,13 @@ naming:
     minimumFunctionNameLength: 3
   FunctionNaming:
     active: true
-    functionPattern: '^([a-z$][a-zA-Z$0-9]*)|(`.*`)$'
+    functionPattern: '[a-zA-Z][a-zA-Z0-9]*'
     ignoreAnnotated: [ 'Composable' ]
   MatchingDeclarationName:
     active: true
   MemberNameEqualsClassName:
     active: false
-    ignoreOverriddenFunction: true
+    ignoreOverridden: true
   ObjectPropertyNaming:
     active: true
     propertyPattern: '[A-Za-z][_A-Za-z0-9]*'
@@ -244,7 +244,7 @@ potential-bugs:
     active: false
   LateinitUsage:
     active: false
-    excludeAnnotatedProperties: ""
+    ignoreAnnotated: [ '' ]
     ignoreOnClassesPattern: ""
   UnconditionalJumpStatementInLoop:
     active: false
@@ -272,10 +272,10 @@ style:
     active: false
   ForbiddenComment:
     active: true
-    values: 'FIXME:,STOPSHIP:'
+    values: [ 'FIXME:', 'STOPSHIP:' ]
   ForbiddenImport:
     active: false
-    imports: ''
+    imports: [ '' ]
   FunctionOnlyReturningConstant:
     active: false
     ignoreOverridableFunction: true
@@ -285,7 +285,7 @@ style:
     maxJumpCount: 1
   MagicNumber:
     active: true
-    ignoreNumbers: '-1,0,1,2'
+    ignoreNumbers: [ '-1', '0', '1', '2' ]
     ignoreHashCodeFunction: false
     ignorePropertyDeclaration: true
     ignoreConstantDeclaration: true
@@ -342,7 +342,7 @@ style:
     ignoreAnnotated: [ 'Preview' ]
   UseDataClass:
     active: false
-    excludeAnnotatedClasses: ""
+    ignoreAnnotated: [ '' ]
   UtilityClassWithPublicConstructor:
     active: false
   WildcardImport:

diff --git a/sample-xml/detekt-config.yml b/sample-xml/detekt-config.yml
@@ -70,7 +70,7 @@ complexity:
     threshold: 20
   LongParameterList:
     active: true
-    threshold: 5
+    functionThreshold: 5
     ignoreDefaultParameters: false
   MethodOverloading:
     active: false
@@ -127,7 +127,7 @@ exceptions:
   active: true
   ExceptionRaisedInUnexpectedLocation:
     active: false
-    methodNames: 'toString,hashCode,equals,finalize'
+    methodNames: [ 'toString', 'hashCode', 'equals', 'finalize' ]
   InstanceOfCheckForException:
     active: false
   NotImplementedDeclaration:
@@ -146,28 +146,28 @@ exceptions:
     active: false
   ThrowingExceptionsWithoutMessageOrCause:
     active: false
-    exceptions: 'IllegalArgumentException,IllegalStateException,IOException'
+    exceptions: [ 'IllegalArgumentException', 'IllegalStateException', 'IOException' ]
   ThrowingNewInstanceOfSameException:
     active: false
   TooGenericExceptionCaught:
     active: true
     exceptionNames:
-     - ArrayIndexOutOfBoundsException
-     - Error
-     - Exception
-     - IllegalMonitorStateException
-     - NullPointerException
-     - IndexOutOfBoundsException
-     - RuntimeException
-     - Throwable
+      - ArrayIndexOutOfBoundsException
+      - Error
+      - Exception
+      - IllegalMonitorStateException
+      - NullPointerException
+      - IndexOutOfBoundsException
+      - RuntimeException
+      - Throwable
   TooGenericExceptionThrown:
     active: true
     exceptionNames:
-     - Error
-     - Exception
-     - NullPointerException
-     - Throwable
-     - RuntimeException
+      - Error
+      - Exception
+      - NullPointerException
+      - Throwable
+      - RuntimeException
 
 naming:
   active: true
@@ -179,7 +179,7 @@ naming:
     enumEntryPattern: '^[A-Z$][a-zA-Z_$]*$'
   ForbiddenClassName:
     active: false
-    forbiddenName: ''
+    forbiddenName: [ '' ]
   FunctionMaxLength:
     active: false
     maximumFunctionNameLength: 30
@@ -188,12 +188,12 @@ naming:
     minimumFunctionNameLength: 3
   FunctionNaming:
     active: true
-    functionPattern: '^([a-z$][a-zA-Z$0-9]*)|(`.*`)$'
+    functionPattern: '[a-zA-Z][a-zA-Z0-9]*'
   MatchingDeclarationName:
     active: true
   MemberNameEqualsClassName:
     active: false
-    ignoreOverriddenFunction: true
+    ignoreOverridden: true
   ObjectPropertyNaming:
     active: true
     propertyPattern: '[A-Za-z][_A-Za-z0-9]*'
@@ -243,7 +243,7 @@ potential-bugs:
     active: false
   LateinitUsage:
     active: false
-    excludeAnnotatedProperties: ""
+    ignoreAnnotated: [ '' ]
     ignoreOnClassesPattern: ""
   UnconditionalJumpStatementInLoop:
     active: false
@@ -271,10 +271,10 @@ style:
     active: false
   ForbiddenComment:
     active: true
-    values: 'FIXME:,STOPSHIP:'
+    values: [ 'FIXME:', 'STOPSHIP:' ]
   ForbiddenImport:
     active: false
-    imports: ''
+    imports: [ '' ]
   FunctionOnlyReturningConstant:
     active: false
     ignoreOverridableFunction: true
@@ -284,7 +284,7 @@ style:
     maxJumpCount: 1
   MagicNumber:
     active: true
-    ignoreNumbers: '-1,0,1,2'
+    ignoreNumbers: [ '-1', '0', '1', '2' ]
     ignoreHashCodeFunction: false
     ignorePropertyDeclaration: false
     ignoreConstantDeclaration: true
@@ -336,9 +336,11 @@ style:
     active: false
   UnusedImports:
     active: false
+  UnusedPrivateMember:
+    active: true
   UseDataClass:
     active: false
-    excludeAnnotatedClasses: ""
+    ignoreAnnotated: [ '' ]
   UtilityClassWithPublicConstructor:
     active: false
   WildcardImport:

diff --git a/template-compose/detekt-config.yml b/template-compose/detekt-config.yml
@@ -70,7 +70,7 @@ complexity:
     threshold: 20
   LongParameterList:
     active: true
-    threshold: 5
+    functionThreshold: 5
     ignoreDefaultParameters: true
   MethodOverloading:
     active: false
@@ -127,7 +127,7 @@ exceptions:
   active: true
   ExceptionRaisedInUnexpectedLocation:
     active: false
-    methodNames: 'toString,hashCode,equals,finalize'
+    methodNames: [ 'toString', 'hashCode', 'equals' , 'finalize' ]
   InstanceOfCheckForException:
     active: false
   NotImplementedDeclaration:
@@ -146,28 +146,28 @@ exceptions:
     active: false
   ThrowingExceptionsWithoutMessageOrCause:
     active: false
-    exceptions: 'IllegalArgumentException,IllegalStateException,IOException'
+    exceptions: [ 'IllegalArgumentException', 'IllegalStateException', 'IOException' ]
   ThrowingNewInstanceOfSameException:
     active: false
   TooGenericExceptionCaught:
     active: true
     exceptionNames:
-     - ArrayIndexOutOfBoundsException
-     - Error
-     - Exception
-     - IllegalMonitorStateException
-     - NullPointerException
-     - IndexOutOfBoundsException
-     - RuntimeException
-     - Throwable
+      - ArrayIndexOutOfBoundsException
+      - Error
+      - Exception
+      - IllegalMonitorStateException
+      - NullPointerException
+      - IndexOutOfBoundsException
+      - RuntimeException
+      - Throwable
   TooGenericExceptionThrown:
     active: true
     exceptionNames:
-     - Error
-     - Exception
-     - NullPointerException
-     - Throwable
-     - RuntimeException
+      - Error
+      - Exception
+      - NullPointerException
+      - Throwable
+      - RuntimeException
 
 naming:
   active: true
@@ -179,7 +179,7 @@ naming:
     enumEntryPattern: '^[A-Z$][a-zA-Z_$]*$'
   ForbiddenClassName:
     active: false
-    forbiddenName: ''
+    forbiddenName: [ '' ]
   FunctionMaxLength:
     active: false
     maximumFunctionNameLength: 30
@@ -188,13 +188,13 @@ naming:
     minimumFunctionNameLength: 3
   FunctionNaming:
     active: true
-    functionPattern: '^([a-z$][a-zA-Z$0-9]*)|(`.*`)$'
+    functionPattern: '[a-zA-Z][a-zA-Z0-9]*'
     ignoreAnnotated: [ 'Composable' ]
   MatchingDeclarationName:
     active: true
   MemberNameEqualsClassName:
     active: false
-    ignoreOverriddenFunction: true
+    ignoreOverridden: true
   ObjectPropertyNaming:
     active: true
     propertyPattern: '[A-Za-z][_A-Za-z0-9]*'
@@ -244,7 +244,7 @@ potential-bugs:
     active: false
   LateinitUsage:
     active: false
-    excludeAnnotatedProperties: ""
+    ignoreAnnotated: [ '' ]
     ignoreOnClassesPattern: ""
   UnconditionalJumpStatementInLoop:
     active: false
@@ -272,10 +272,10 @@ style:
     active: false
   ForbiddenComment:
     active: true
-    values: 'FIXME:,STOPSHIP:'
+    values: [ 'FIXME:', 'STOPSHIP:' ]
   ForbiddenImport:
     active: false
-    imports: ''
+    imports: [ '' ]
   FunctionOnlyReturningConstant:
     active: false
     ignoreOverridableFunction: true
@@ -285,7 +285,7 @@ style:
     maxJumpCount: 1
   MagicNumber:
     active: true
-    ignoreNumbers: '-1,0,1,2'
+    ignoreNumbers: [ '-1', '0', '1', '2' ]
     ignoreHashCodeFunction: false
     ignorePropertyDeclaration: true
     ignoreConstantDeclaration: true
@@ -342,7 +342,7 @@ style:
     ignoreAnnotated: [ 'Preview' ]
   UseDataClass:
     active: false
-    excludeAnnotatedClasses: ""
+    ignoreAnnotated: [ '' ]
   UtilityClassWithPublicConstructor:
     active: false
   WildcardImport: