[#303] Update detekt ruels for Compose

nimblehq · Dec 8, 2022 · 0cefd11 · 0cefd11
1 parent 4be59c0
commit 0cefd11
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 15 deletions.
diff --git a/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/theme/Color.kt b/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/theme/Color.kt
@@ -1,5 +1,3 @@
-@file:Suppress("MagicNumber")
-
 package co.nimblehq.sample.compose.ui.theme
 
 import androidx.compose.ui.graphics.Color

diff --git a/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/theme/Dimension.kt b/sample-compose/app/src/main/java/co/nimblehq/sample/compose/ui/theme/Dimension.kt
@@ -1,5 +1,3 @@
-@file:Suppress("MagicNumber")
-
 package co.nimblehq.sample.compose.ui.theme
 
 import androidx.compose.ui.unit.dp

diff --git a/sample-compose/detekt-config.yml b/sample-compose/detekt-config.yml
@@ -71,7 +71,7 @@ complexity:
   LongParameterList:
     active: true
     threshold: 5
-    ignoreDefaultParameters: false
+    ignoreDefaultParameters: true
   MethodOverloading:
     active: false
     threshold: 5
@@ -189,7 +189,7 @@ naming:
   FunctionNaming:
     active: true
     functionPattern: '^([a-z$][a-zA-Z$0-9]*)|(`.*`)$'
-    ignoreAnnotated: [ 'Composable' ]
+    ignoreAnnotated: ['Composable']
   MatchingDeclarationName:
     active: true
   MemberNameEqualsClassName:
@@ -204,7 +204,7 @@ naming:
   TopLevelPropertyNaming:
     active: true
     constantPattern: '[A-Z][_A-Z0-9]*'
-    propertyPattern: '[A-Z][A-Za-z0-9]*'
+    propertyPattern: '[A-Za-z][_A-Za-z0-9]*'
     privatePropertyPattern: '(_)?[a-z][A-Za-z0-9]*'
   VariableMaxLength:
     active: false
@@ -287,7 +287,7 @@ style:
     active: true
     ignoreNumbers: '-1,0,1,2'
     ignoreHashCodeFunction: false
-    ignorePropertyDeclaration: false
+    ignorePropertyDeclaration: true
     ignoreConstantDeclaration: true
     ignoreCompanionObjectPropertyDeclaration: true
     ignoreAnnotation: false

diff --git a/...late-compose/app/src/main/java/co/nimblehq/template/compose/ui/screens/home/HomeScreen.kt b/...late-compose/app/src/main/java/co/nimblehq/template/compose/ui/screens/home/HomeScreen.kt
@@ -12,7 +12,6 @@ import co.nimblehq.template.compose.ui.theme.Dimension.SpacingNormal
 import co.nimblehq.template.compose.ui.theme.Theme
 import timber.log.Timber
 
-@Suppress("FunctionNaming")
 @ExperimentalComposeUiApi
 @Composable
 fun HomeScreen(

diff --git a/template-compose/app/src/main/java/co/nimblehq/template/compose/ui/theme/Color.kt b/template-compose/app/src/main/java/co/nimblehq/template/compose/ui/theme/Color.kt
@@ -2,7 +2,6 @@ package co.nimblehq.template.compose.ui.theme
 
 import androidx.compose.ui.graphics.Color
 
-@Suppress("MagicNumber")
 object Color {
     val GreenCitrus = Color(0xFF99CC00)
     val GreenChristi = Color(0xFF669900)

diff --git a/template-compose/app/src/main/java/co/nimblehq/template/compose/ui/theme/Dimension.kt b/template-compose/app/src/main/java/co/nimblehq/template/compose/ui/theme/Dimension.kt
@@ -2,7 +2,6 @@ package co.nimblehq.template.compose.ui.theme
 
 import androidx.compose.ui.unit.dp
 
-@Suppress("MagicNumber")
 object Dimension {
     val SpacingNormal = 16.dp
 }
diff --git a/template-compose/app/src/main/java/co/nimblehq/template/compose/ui/theme/Theme.kt b/template-compose/app/src/main/java/co/nimblehq/template/compose/ui/theme/Theme.kt
@@ -4,7 +4,6 @@ import androidx.compose.material.MaterialTheme
 import androidx.compose.material.lightColors
 import androidx.compose.runtime.Composable
 
-@Suppress("FunctionNaming")
 @Composable
 fun Theme(
     content: @Composable () -> Unit

diff --git a/template-compose/detekt-config.yml b/template-compose/detekt-config.yml
@@ -71,7 +71,7 @@ complexity:
   LongParameterList:
     active: true
     threshold: 5
-    ignoreDefaultParameters: false
+    ignoreDefaultParameters: true
   MethodOverloading:
     active: false
     threshold: 5
@@ -189,6 +189,7 @@ naming:
   FunctionNaming:
     active: true
     functionPattern: '^([a-z$][a-zA-Z$0-9]*)|(`.*`)$'
+    ignoreAnnotated: ['Composable']
   MatchingDeclarationName:
     active: true
   MemberNameEqualsClassName:
@@ -203,7 +204,7 @@ naming:
   TopLevelPropertyNaming:
     active: true
     constantPattern: '[A-Z][_A-Z0-9]*'
-    propertyPattern: '[a-z][A-Za-z\d]*'
+    propertyPattern: '[A-Za-z][_A-Za-z0-9]*'
     privatePropertyPattern: '(_)?[a-z][A-Za-z0-9]*'
   VariableMaxLength:
     active: false
@@ -286,7 +287,7 @@ style:
     active: true
     ignoreNumbers: '-1,0,1,2'
     ignoreHashCodeFunction: false
-    ignorePropertyDeclaration: false
+    ignorePropertyDeclaration: true
     ignoreConstantDeclaration: true
     ignoreCompanionObjectPropertyDeclaration: true
     ignoreAnnotation: false