Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce RxJS dependency #2292

Merged
merged 1 commit into from
Jan 3, 2025
Merged

refactor: reduce RxJS dependency #2292

merged 1 commit into from
Jan 3, 2025

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Jan 3, 2025

In this commit, we reduce the usage of RxJS utilities as they may be redundant. For example,
we replace the replay subject with a behavior subject and remove some unnecessary operators.

@arturovt arturovt force-pushed the refactor/reduce-rxjs branch from 1d82c92 to c19fc4b Compare January 3, 2025 08:15
Copy link

nx-cloud bot commented Jan 3, 2025

View your CI Pipeline Execution ↗ for commit 3c3c24f.

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 21s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 1s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 34s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-03 08:31:29 UTC

Copy link

pkg-pr-new bot commented Jan 3, 2025

Open in Stackblitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2292

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2292

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2292

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2292

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2292

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2292

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2292

commit: 3c3c24f

Copy link

bundlemon bot commented Jan 3, 2025

BundleMon

Unchanged files (6)
Status Path Size Limits
fesm2022/ngxs-store.mjs
104.93KB 105KB / +0.5%
fesm2022/ngxs-store-internals.mjs
11.82KB 13KB / +0.5%
fesm2022/ngxs-store-internals-testing.mjs
6.8KB 7KB / +0.5%
fesm2022/ngxs-store-operators.mjs
6.22KB 7KB / +0.5%
fesm2022/ngxs-store-plugins.mjs
2.38KB 3KB / +0.5%
fesm2022/ngxs-store-experimental.mjs
574B 2KB / +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
@ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
31.94KB +1%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Jan 3, 2025

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
3.98KB +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
2.96KB +0.5%
Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
2.63KB +0.5%
Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
2.56KB +0.5%
Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
2.46KB +0.5%
Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
2.15KB +0.5%
Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
2.01KB +0.5%
Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
861B +0.5%
Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
396B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
19.96KB +0.5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

bundlemon bot commented Jan 3, 2025

BundleMon (Integration Projects)

Files added (1)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng19/dist-integration/browser/mai
n-(hash).js
+66.36KB +1%
Files removed (3)
Status Path Size Limits
Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
-70.1KB +1%
Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
-68.24KB +1%
Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
-67.3KB +1%

Total files change -139.28KB -67.73%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

In this commit, we reduce the usage of RxJS utilities as they may be redundant. For example,
we replace the replay subject with a behavior subject and remove some unnecessary operators.
@arturovt arturovt force-pushed the refactor/reduce-rxjs branch from c19fc4b to 3c3c24f Compare January 3, 2025 08:27
@arturovt arturovt marked this pull request as ready for review January 3, 2025 08:28
@arturovt arturovt merged commit 56b9e7d into master Jan 3, 2025
1 of 4 checks passed
@arturovt arturovt deleted the refactor/reduce-rxjs branch January 3, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant