Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: NJS cacheable variables with access log #1188

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

andrey-zelenkov
Copy link
Contributor

Reproduces issue #1169.

@andrey-zelenkov
Copy link
Contributor Author

Rebased and removed unused iterator.

% git range-diff afe8b31d...287fb378
 -:  -------- >  1:  0d99744d Router: match when pattern and tested string are both zero length
 -:  -------- >  2:  fdc46759 NJS: avoiding arithmetic ops with NULL pointer in r->args
 -:  -------- >  3:  8844d33c Fixed undefined behaviour in left shift of int value
 -:  -------- >  4:  7dcd6c0e Avoiding arithmetic ops with NULL pointer in nxt_http_arguments_parse
 -:  -------- >  5:  264b3755 Avoiding arithmetic ops with NULL pointer in nxt_port_mmap_get
 -:  -------- >  6:  c9461a6b Initialize port_impl only when it is needed
 -:  -------- >  7:  dd701fb4 Avoiding arithmetic ops with NULL pointer in nxt_unit_mmap_get
 -:  -------- >  8:  abcfc4cd Fix the security-alert email link in the README
 -:  -------- >  9:  9993814d NJS: loader should be registered using njs_vm_set_module_loader()
 1:  afe8b31d ! 10:  287fb378 Tests: NJS cacheable variables with access log
    @@ test/test_njs.py: def test_njs_variables_cacheable(temp_dir):
     +    ), 'access_log configure'
     +
     +    reqs = 50
    -+    for i in range(reqs):
    ++    for _ in range(reqs):
     +        client.get()
     +
     +    assert len(findall(r'localhost, 200', 'access.log')) == reqs

@andrey-zelenkov andrey-zelenkov merged commit 0716b0c into nginx:master Mar 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants