simplify package dependency #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Various cleanups are possible in the spec template Can be safely removed
|
|
The 2ac4a75 change is exactly there because we don't have a proper API that can be exposed, and we need to make sure modules are installed alongside the builds we provide. Relying on Other cleanup you mention is OK I guess, provided it's not required by the OSes we still support (e.g. Amazon Linux 2, CentOS 7). |
Pushed in second commit
Feel free to apply only the second commit if you prefer |
|
Not sure why this has lingered quite so long. Let's apply Remi's second patch. In preparation, we should also drop Amazon Linux 2 (EOL in 1 yr) and CentOS 7 (EOL in 2 weeks) support. We may cut further, but these two shouldn't be controversial. Any takers on doing the needful? Maybe @ac000 or @javorszky? (Or @thresheek if you've got spare cycles) |
|
@remicollet can you comment on why you were suggesting removing |
|
(I'll go cross-reference the obsoletion of buildroot against our matrix of supported distros to make sure we're in the clear there) |
|
Seems Fedora has indeed deprecated the use of the |
|
The 'Group' and 'BuildRoot' tags have been declared as deprecated by the Fedora project. Also, to quote the Fedora Packaging Guidelines The contents of the buildroot SHOULD NOT be removed in the first line of %install. The %defattr directive in the %files list SHOULD ONLY be used when setting a non-default value, or to reset to the default value after having set a non-default value. Link: <https://fedoraproject.org/wiki/RPMGroups> Link: <https://fedoraproject.org/wiki/Phase_out_buildroot_tag_(draft)> Link: <https://fedoraproject.org/wiki/Archive:PackagingDrafts/BuildRoot> Link: <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections> [ Tweaked subject & added commit message - Andrew ] Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
|
Rebase with master... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
unit-r1.31.1was introduced in 2ac4a75Requires: unit = %{version}is simpler, allows any release of the same version, and avoids additional metadataA specific virtual provide will make sense for an API number (for the future)
Example in unit
Provides: unit(ABI) = 12Example for module
%{unit_api}being defined in a rpm macro file provided by unit-devel