Skip to content

Commit

Permalink
Update to sync with tk-framework-widget PR shotgunsoftware#15 (shotgu…
Browse files Browse the repository at this point in the history
…nsoftware#23)

* Update SceneBrowserWidget to use the Worker's notifier to listen for completed and failed signals.
* Update info.yml to require tk-framework-widget v1.x.x to include necessary update to Worker class.
* Update test.yml with latest tk-framework-widget version.
  • Loading branch information
staceyoue authored Oct 1, 2020
1 parent e0de23e commit 38f21ba
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,5 +48,5 @@ supported_engines:

# the frameworks required to run this app
frameworks:
- {"name": "tk-framework-widget", "version": "v0.2.x"}
- {"name": "tk-framework-widget", "version": "v1.x.x"}
- {"name": "tk-framework-shotgunutils", "version": "v5.x.x", "minimum_version": "v5.2.1"}
4 changes: 2 additions & 2 deletions python/tk_multi_breakdown/scene_browser.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ def set_app(self, app):
browser_widget.BrowserWidget.set_app(self, app)
# For some reason connecting the worker signal directly to the child items' slots causes a
# segmentation fault when there are many items. But re-emitting a local signal works fine
self._worker.work_completed.connect(
self._worker.notifier.work_completed.connect(
lambda uid, data: self._item_work_completed.emit(uid, data)
)
self._worker.work_failure.connect(
self._worker.notifier.work_failure.connect(
lambda uid, msg: self._item_work_failed.emit(uid, msg)
)

Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/config/env/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ engines:


frameworks:
tk-framework-widget_v0.2.x:
tk-framework-widget_v1.x.x:
location: {type: dev, path: '$SHOTGUN_REPOS_ROOT/tk-framework-widget' }
tk-framework-shotgunutils_v5.x.x:
location: {type: dev, path: '$SHOTGUN_REPOS_ROOT/tk-framework-shotgunutils' }
Expand Down

0 comments on commit 38f21ba

Please sign in to comment.