Skip to content

Commit

Permalink
Merge pull request #478 from nf-core/dev
Browse files Browse the repository at this point in the history
Patch release 1.1.7
  • Loading branch information
LilyAnderssonLee authored Apr 29, 2024
2 parents 45ce748 + ab32e91 commit f1e6153
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 28 deletions.
14 changes: 14 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,20 @@
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v1.1.7 - Augmented Akita Patch [2024-04-25]

### `Added`

- [#477](https://github.com/nf-core/taxprofiler/pull/477) Provide more emphasis and links to tutorials on how to retrieve and supply reference databases (❤️ to @vmkalbskopf for reporting, added by @jfy133)

### `Fixed`

- [#476](https://github.com/nf-core/taxprofiler/pull/476/) Fixed bug in validating Bracken/Kraken/KMCP split database parameters (fixed by @LilyAnderssonLee)

### `Dependencies`

### `Deprecated`

## v1.1.6 - Augmented Akita Patch [2024-04-16]

### `Added`
Expand Down
4 changes: 2 additions & 2 deletions assets/multiqc_config.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
report_comment: >
This report has been generated by the <a href="https://github.com/nf-core/taxprofiler/releases/tag/1.1.6" target="_blank">nf-core/taxprofiler</a>
This report has been generated by the <a href="https://github.com/nf-core/taxprofiler/releases/tag/1.1.7" target="_blank">nf-core/taxprofiler</a>
analysis pipeline. For information about how to interpret these results, please see the
<a href="https://nf-co.re/taxprofiler/1.1.6/docs/output" target="_blank">documentation</a>.
<a href="https://nf-co.re/taxprofiler/1.1.7/docs/output" target="_blank">documentation</a>.
report_section_order:
"nf-core-taxprofiler-methods-description":
Expand Down
18 changes: 0 additions & 18 deletions assets/schema_database.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,24 +36,6 @@
"db_params": {
"type": "string",
"pattern": "^[^\"']*$",
"anyOf": [
{
"properties": {
"tool": { "const": "bracken" }
},
"not": {
"pattern": ".*;"
},
"errorMessage": "Invalid database db_params entry. Bracken requires a semi-colon for passing one or more parameters."
},
{
"properties": {
"tool": { "const": "kmcp" }
},
"pattern": ".*;$",
"errorMessage": "Invalid database `db_params` entry. KMCP only requires a semi-colon if passing arguments to KMCP profile, in cases of which the arguments should go after the semi-colon."
}
],
"errorMessage": "Invalid database db_params entry. No quotes allowed.",
"meta": ["db_params"]
},
Expand Down
13 changes: 7 additions & 6 deletions docs/usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ nf-core/taxprofiler supports multiple databases being classified/profiled agains
Databases can be supplied either in the form of a compressed `.tar.gz` archive of a directory containing all relevant database files or the path to a directory on the filesystem.

:::warning
nf-core/taxprofiler does not provide any databases by default, nor does it currently generate them for you. This must be performed manually by the user. See bottom of this section for more information of the expected database files, or the [building custom database](usage/tutorials#retrieving-databases-or-building-custom-databases) tutorials.
nf-core/taxprofiler does not provide any databases by default, nor does it currently generate them for you. This must be performed manually by the user. See bottom of this section for more information of the expected database files, or the [building databases](usage/tutorials#retrieving-databases-or-building-custom-databases) tutorial.
:::

The pipeline takes the paths and specific classification/profiling parameters of the tool of these databases as input via a four column comma-separated sheet.
Expand Down Expand Up @@ -128,7 +128,7 @@ For Bracken and KMCP, which are two step profilers, nf-core/taxprofiler has a sp

For Bracken, if you wish to supply any parameters to both the Kraken or Bracken steps or just the Bracken step, you **must** have a _semi-colon_ `;` list in the `db_params` column. This allows you to specify the Kraken2 parameters before and Bracken parameters after the `;`. This is particularly important if you supply a Bracken database with a non-default read length parameter. If you do not have any parameters to specify, you can leave this column empty. If you wish to provide settings to _just_ the Kraken2 step of the Bracken profiling, you can supply a normal string to the column without a semi-colon. If you wish to supply parameters to only Bracken (and keep default Kraken2 parameters), then you supply a string to the column starting with `;` and the Bracken parameters _after_.

Similiarly, for KMCP, if you want to supply parameters for both the first (KMCP search) and the _second step_ (KMCP profile) steps, you **must** have a _semi-colon_ separated`;` list in `db_params`. If you wish to provide parameters to just KMCP search, you do not need the `;`. If you want to supply parameters to just KMCP profile (and keep search parameters at default), then you must start the string with `;` and the KMCP profile parameters come _after_ the semi colon. If you do not wish to modify any parameters, you can leave the column empty (i.e. the `;` is not necessary).
Similarly, for KMCP, if you want to supply parameters for both the first (KMCP search) and the _second step_ (KMCP profile) steps, you **must** have a _semi-colon_ separated`;` list in `db_params`. If you wish to provide parameters to just KMCP search, you do not need the `;`. If you want to supply parameters to just KMCP profile (and keep search parameters at default), then you must start the string with `;` and the KMCP profile parameters come _after_ the semi colon. If you do not wish to modify any parameters, you can leave the column empty (i.e. the `;` is not necessary).

This allows you to specify the KMCP search and the KMCP profile parameters, separated by `;`. If you do not have any parameters to specify, you can leave this as empty.
:::
Expand All @@ -148,6 +148,10 @@ You can also specify the same database directory/file twice (ensuring unique `db

nf-core/taxprofiler will automatically decompress and extract any compressed archives for you.

:::tip
Click the links in the list below for short quick-reference tutorials how to generate download 'pre-made' and/or custom databases for each tool.
:::

The (uncompressed) database paths (`db_path`) for each tool are expected to contain:

- [**Bracken**:](usage/tutorials.md#bracken-custom-database) output of the combined `kraken2-build` and `bracken-build` process.
Expand All @@ -159,13 +163,10 @@ The (uncompressed) database paths (`db_path`) for each tool are expected to cont
- [**MALT**](usage/tutorials.md#malt-custom-database) output of `malt-build`.
- [**MetaPhlAn**:](usage/tutorials.md#metaphlan-custom-database) output of with `metaphlan --install` or downloaded from links on the [MetaPhlAn wiki](https://github.com/biobakery/MetaPhlAn/wiki/MetaPhlAn-4#customizing-the-database).
- [**mOTUs**:](usage/tutorials.md#motus-custom-database) the directory `db_mOTU/` that is downloaded via `motus downloadDB`.
- Note that you must use `motus downloadDB` and if installed via `conda`, will be placed in a specific `site-package` directory in the conda environment. For more details see the [mOTUs database tutorial](usage/tutorials.md#motus-custom-database).
- [**ganon**:](usage/tutorials.md#ganon-custom-database) output of `ganon build` or `ganon build-custom`.
- [**KMCP**:](usage/tutorials.md#kmcp-custom-database) output of `kmcp index`. Note: `kmcp index` uses the output of an upstream `kmcp compute` step.

:::info
Click the links in the list above for short quick-reference tutorials how to generate custom databases for each tool.
:::

## Running the pipeline

The typical command for running the pipeline is as follows:
Expand Down
2 changes: 1 addition & 1 deletion docs/usage/tutorials.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ tar -xzf kaiju.tar.gz
```

:::note
You have provide these databases pre-built to the pipeline, nf-core/taxprofiler neither comes with default databases not can generate databases for you.
You must provide these databases pre-built to the pipeline, nf-core/taxprofiler neither comes with default databases not can generate databases for you.
For guidance on how to build databases, see the [Retrieving databases or building custom databases](#retrieving-databases-or-building-custom-databases) tutorial.
:::

Expand Down
2 changes: 1 addition & 1 deletion nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ manifest {
description = """Taxonomic classification and profiling of shotgun short- and long-read metagenomic data"""
mainScript = 'main.nf'
nextflowVersion = '!>=23.04.0'
version = '1.1.6'
version = '1.1.7'
doi = '10.1101/2023.10.20.563221'

}
Expand Down

0 comments on commit f1e6153

Please sign in to comment.