avoid duplicated messages after sending #4688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-21.0 |
It could happen that when sending a message it was received on server but if the servers response is not received, the retry was triggered in the talk app. This sometimes happened when internet connection was not the best. Best would be that messages with the same referenceId would be refused on server side, but this won't be the case for now. So messages with the same referenceId are NOT refused as this would be too much overhead as there would be additional queries on server for every received message) For now, the automatic retry logic is just removed so duplicated messages won't be created automatically. However it's still possible to manually trigger the retry via button. In this case it is not guaranteed that there won't be duplicates. Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi
force-pushed
the
bugfix/noid/avoidDuplicatedMessagesAfterSend
branch
from
0fdd10f to
09a6cfb
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4688-talk.apk |
sowjanyakch
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could happen that when sending a message it was received on server but if the servers response is not received, the retry was triggered in the talk app. This sometimes happened when internet connection was not the best.
Best would be that messages with the same referenceId would be refused on server side, but this won't be the case for now. So messages with the same referenceId are NOT refused as this would be too much overhead as there would be additional queries on server for every received message)
For now, the automatic retry logic is just removed so duplicated messages won't be created automatically. However it's still possible to manually trigger the retry via button. In this case it is not guaranteed that there won't be duplicates.
Also see comment #2171 (comment)
🏁 Checklist
/backport to stable-xx.x