feat(ocs): list accounts and aliases of current user #10735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
requested review from
ChristophWurst,
kesselb and
GretaD
as code owners
|
cc @marcelklehr in case you have remarks regarding the schema or you have suggestions for improvements |
st3iny
commented
Feb 20, 2025
Comment on lines
+20
to
+21
| * @method void setName(string|null $name) | ||
| * @method string|null getName() |
There was a problem hiding this comment.
Not strictly related but I noticed that the DB schema allows null values but the entity does not. Otherwise, I can't write a unit test for null values of the name column.
marcelklehr
approved these changes
Feb 25, 2025
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
feat/ocs/list-accounts
branch
from
f88d30b to
8122306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10588
Exemplary API response
GET https://localhost/ocs/v2.php/apps/mail/account/list{ "ocs": { "meta": { "status": "ok", "statuscode": 200, "message": "OK" }, "data": [ { "id": 1720, "email": "user@imap.localhost", "aliases": [ { "id": 51, "email": "null@imap.localhost", "name": null } ] }, { "id": 1724, "email": "bob@stalwart.localhost", "aliases": [] }, { "id": 2101, "email": "debug@imap.localhost", "aliases": [ { "id": 49, "email": "catchall@imap.localhost", "name": "catchall" } ] }, ] } }