-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document GUI Standards. #7
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #7 +/- ##
==========================================
+ Coverage 84.09% 88.82% +4.73%
==========================================
Files 7 9 +2
Lines 88 179 +91
==========================================
+ Hits 74 159 +85
- Misses 14 20 +6 ☔ View full report in Codecov by Sentry. |
|
||
Buttons should also be given meaningful names, such as “Load Experiment Plan” rather than | ||
generic names like “Load”. If multiple buttons exist in the View, it should be clear to the | ||
use which input/output fields correspond to each button. This can be achieved through grouping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user
I recommend renaming the section called Algorithm Input Validation to something more like Data Input Validation. I like that there are two types of validation
It is not clear that all data entered by a user will be directly used in an algorithm. I would prefer a more generic term for this type of validation and not focus (limit) it to algorithms. Error Handling, perhaps better would be visual error handling. This is not the error handling strategy, but more how to inform the user when something goes wrong. We should add a link in here to the Error Handling strategy (I think this is being covered by loggging). |
src/garnet/base/base_lineedit.py
Outdated
@@ -0,0 +1,81 @@ | |||
"""BaseLineEdit | |||
------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please create a folder called utility and inside create another called UIelements or similar; include the base_lineedit.py and base_statusbar.py there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected
* Document GUI Standards. * update pics * update view and docs * move helper classes * remove required style if default value
Description of Changes:
Document GUI standards with some examples.
Related Items
To Test:
Check list for the pull request
Check list for the reviewer