Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing and packaging files #325

Merged
merged 23 commits into from
Jan 9, 2025
Merged

Add testing and packaging files #325

merged 23 commits into from
Jan 9, 2025

Conversation

ktactac-ornl
Copy link
Collaborator

@ktactac-ornl ktactac-ornl commented Dec 18, 2024

Short description of the changes:

Migrates gitlab CI to github

Long description of the changes:

  • create GH CI files
  • delete GL CI files
  • move issue/PR templates
  • update an annoying version test without affecting its purpose

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

8190: [DRTSANS] Migrating the source to GitHub

@glass-ships
Copy link
Member

not by any means necessary, but this could be a good opportunity to test out packaging via pixi - there's a setup-pixi github action we can use.

but also i could just play around with that in a separate PR.

@glass-ships
Copy link
Member

glass-ships commented Dec 19, 2024

you may have figured it out already but test_simple is failing because versioningit is set to get the latest version from our tags, but github doesn't have any tags yet - those are still in gitlab

i straight up lied, we definitely have the tags in gh too. not sure why my pipeline is failing to grab the right version...

@glass-ships
Copy link
Member

looks good!

only other question i have is, i see we do git submodule update --init but i don't see any steps for git lfs, so we're skipping a lot of tests.

is that something you're still working on?

@ktactac-ornl ktactac-ornl force-pushed the ewm8190_setup_github_ci branch from ecf62ad to 847187f Compare December 20, 2024 04:45
@jmborr jmborr self-requested a review January 7, 2025 15:59
@ktactac-ornl ktactac-ornl merged commit 6fc28bd into next Jan 9, 2025
2 checks passed
@ktactac-ornl ktactac-ornl deleted the ewm8190_setup_github_ci branch January 9, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants