Capitalize Filter Form Labels #16230
Conversation
|
Sorry this is a big one! |
|
Related to 16104 |
|
Fixed the link, thank you @mr1716 |
|
@danner26 thanks for taking a look at this and creating a PR. Hoping this will be merged soon as this is a good improvement (low priority, but sadly something I can’t unsee) for the tool. |
There was a problem hiding this comment.
@jeremystretch looks like just the label strings are changed here, however didn't know if the .po files should be changed in the PR - thinking they should get auto-updated?
|
If the translation files get auto-updated that would make this a lot easier. Please let me know if that is the case so I can remove those changes |
|
Who arbitrarily decided that the field labels all needed to use title case? Why are we modifying test data? To be frank, there are currently 58 open bugs, and this is not where we need to be spending time right now. |
|
@jeremystretch An example of this is the DCIM.Devices Filter Form, which has inconsistencies with wording such as Contact Group vs Tenant group. It doesnt matter how or when it's rectified, but this can be found across almost all filter forms. A real life example is that I wanted to have my team use Netbox, but the feedback that I got was to fix this. It is a minor issue and annoyance, but is noticeable. I want to improve Netbox so it can be the best it can be. I dont care if multi word filters are capitalized or not, but the inconsistency is the issue.
|
|
The scope of #16104 is simply to standardize the capitalization of form field labels, which, to be clear, is to not use title case. (Only the first word needs to be capitalized.) Anything beyond this - filter sets, documentation, tests, etc. - is out of scope for the PR. @danner26 it's up to you whether you want to greatly reduce the scope of these changes or leave it for someone else.
This seems like an odd place to start, given there are so many issues with much higher priority in need of an owner. |
Just because it isn’t a high or medium priority item to fix, that doesn’t mean that it isn’t a legitimate issue that needs to be fixed. And that’s why I opened it, as an improvement is an improvement. Figured it’s a low hanging fruit item that I could use to help me understand how the Netbox tool works and how tickets are handled. |
|
@mr1716 every PR must be reviewed, and the time that I and the other maintainers have to spend on them is extremely limited (hence the backlog of ~30 PRs currently). This is why we prioritize work with a substantial impact on the product. I've already spent more time on this issue than I can afford. |
Understood. I'm not asking this to be given a higher priority, nor pushed to the front, nor not reviewed, nor me given special priority. I know that your time is limited, every item has a different priority, and there are more important issues. I appreciate your time on this, as I never intended this to become a complex thing. Thought it was simply going to be "hey, let's decide on a specific standard for naming this stuff, and make a quick change a few files to follow that standard." My apologies for taking your time. |
|
Closing this as the set of changes contained within is wildly out of scope for #16104. |
|
@jeremystretch the scope for is to ensure consistency in capitalization. I had put a bad title on it and have updated accordingly. My apologies for the confusions |
Fixes: #16104
Implement intentional capital filters rather than doing CSS capitalization. See this PR for reference