Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rust-postgres on rebase #10561

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Jan 29, 2025

I tried a full update of our tokio-postgres fork before. We hit some breaking change. This PR only pulls in ~50% of the changes from upstream: neondatabase/rust-postgres#38.

@conradludgate conradludgate force-pushed the conrad/rust-postgres-rebase branch 2 times, most recently from 5c4c9dc to 882959b Compare January 29, 2025 13:10
@conradludgate conradludgate marked this pull request as ready for review January 29, 2025 13:56
@conradludgate conradludgate requested a review from a team as a code owner January 29, 2025 13:56
Copy link

github-actions bot commented Jan 29, 2025

7440 tests run: 7089 passed, 0 failed, 351 skipped (full report)


Flaky tests (10)

Postgres 17

Postgres 16

Postgres 14

Code coverage* (full report)

  • functions: 33.3% (8497 of 25495 functions)
  • lines: 49.1% (71433 of 145528 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ae32e90 at 2025-01-29T17:11:19.118Z :recycle:

@conradludgate conradludgate force-pushed the conrad/rust-postgres-rebase branch from 882959b to ae32e90 Compare January 29, 2025 15:31
@conradludgate conradludgate removed request for a team, knizhnik and hlinnaka January 29, 2025 15:32
@conradludgate conradludgate requested a review from arpad-m January 29, 2025 15:33
@conradludgate conradludgate added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 190c19c Jan 29, 2025
84 checks passed
@conradludgate conradludgate deleted the conrad/rust-postgres-rebase branch January 29, 2025 17:03
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2025
Update to a rebased version of our rust-postgres patches, rebased on
[this](sfackler/rust-postgres@98f5a11)
commit this time.

With #10280 reapplied, this means that the rust-postgres crates will be
deduplicated, as the new crate versions are finally compatible with the
requirements of diesel-async.

Earlier update: #10561

rust-postgres PR: neondatabase/rust-postgres#39
winter-loo pushed a commit to winter-loo/neon that referenced this pull request Feb 4, 2025
I tried a full update of our tokio-postgres fork before. We hit some
breaking change. This PR only pulls in ~50% of the changes from
upstream: neondatabase/rust-postgres#38.
winter-loo pushed a commit to winter-loo/neon that referenced this pull request Feb 4, 2025
Update to a rebased version of our rust-postgres patches, rebased on
[this](sfackler/rust-postgres@98f5a11)
commit this time.

With neondatabase#10280 reapplied, this means that the rust-postgres crates will be
deduplicated, as the new crate versions are finally compatible with the
requirements of diesel-async.

Earlier update: neondatabase#10561

rust-postgres PR: neondatabase/rust-postgres#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants