Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Vertex AI LLM class #141

Merged
merged 10 commits into from
Sep 19, 2024
Merged

Added Vertex AI LLM class #141

merged 10 commits into from
Sep 19, 2024

Conversation

alexthomas93
Copy link
Contributor

@alexthomas93 alexthomas93 commented Sep 18, 2024 •
edited
Loading

Description

This PR adds an LLM interface for Vertex AI models. It also fixes an import issue with the Embeddings class for Vertex AI.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Complexity: Low

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@alexthomas93 alexthomas93 marked this pull request as ready for review September 18, 2024 14:36
@alexthomas93 alexthomas93 requested review from team-gen-ai and a team September 18, 2024 14:37
willtai
willtai reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@willtai willtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. Is updating documentation part of this PR too?

@alexthomas93
Copy link
Contributor Author

The code looks good to me. Is updating documentation part of this PR too?

Good point I've updated it now

@alexthomas93
Copy link
Contributor Author

@CodiumAI-Agent /update_changelog

@CodiumAI-Agent
Copy link

Changelog updates: 🔄

2024-09-19

Added

  • Introduced Vertex AI LLM class for integrating Vertex AI models.
  • Added unit tests for the Vertex AI LLM class.

Fixed

  • Resolved import issue with the Vertex AI Embeddings class.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

willtai
willtai approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@willtai willtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪢

@alexthomas93 alexthomas93 merged commit d1cef28 into neo4j:main Sep 19, 2024
8 checks passed
@alexthomas93 alexthomas93 deleted the feature/vertexai-llm branch September 19, 2024 15:16
@CodiumAI-Agent
Copy link

Changelog updates: 🔄

2024-09-19

Added

  • Introduced Vertex AI LLM class for integrating Vertex AI models.
  • Added unit tests for the Vertex AI LLM class.

Fixed

  • Resolved import issue with the Vertex AI Embeddings class.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtai willtai willtai approved these changes

@team-gen-ai team-gen-ai Awaiting requested review from team-gen-ai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexthomas93 @CodiumAI-Agent @willtai