Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0 #4426

Merged
merged 186 commits into from
Feb 23, 2024
Merged

5.0.0 #4426

merged 186 commits into from
Feb 23, 2024

Conversation

angrykoala
Copy link
Member

Description

Major release 5.0.0 PR

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 80f06a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@neo4j/graphql Major
@neo4j/graphql-ogm Major
@neo4j/introspector Major
@neo4j/graphql-amqp-subscriptions-engine Major
@neo4j/graphql-toolbox Patch
neo-place Patch
apollo-subscriptions-server Patch
yoga-subscriptions-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Dec 19, 2023

Made some changes to the Neo4j GraphQL Toolbox? Or made some changes to the core library perhaps?

Check out your changes at https://neo4j-graphql-toolbox-4426.surge.sh

Use for instance a local dbms hosted on Neo4j Desktop or a cloud-hosted Aura Free dbms.

@neo4j-team-graphql
Copy link
Collaborator

neo4j-team-graphql commented Dec 19, 2023

Performance Report

No Performance Changes

Show Full Table
name dbHits old dbHits time (ms) old time (ms) maxRows
aggregations.TopLevelAggregate 3404 3404 35 40 1134
aggregations.TopLevelAggregateWithMultipleFields 6802 6802 48 50 1134
aggregations.NestedAggregation 16544 16544 62 82 2174
aggregations.AggregationWithWhere 11970 11970 38 57 2174
aggregations.AggregationWhereWithinNestedRelationships 22116478 22116478 2288 2358 2008534
aggregations.AggregationWhereWithinNestedConnections 22116478 22116478 2268 2470 2008534
aggregations.NestedCountFromMovieToActors 9701 9701 35 40 2174
aggregations.NestedCountFromActorsToMovie 9928 9928 33 37 2174
aggregations.DeeplyNestedCount 11062184 11062184 3004 3104 2008534
aggregations.InterfacesAggregations 6242 6242 45 60 2080
aggregations.InterfacesAggregationsWithTwoFields 11444 11444 70 90 2080
batch-create.BatchCreate 4200 4200 114 162 600
batch-create.BatchCreateSmall 77 77 51 73 11
connect.createAndConnect 14424 14424 203 175 3003
connections.Connection 14049 14049 61 88 2174
connections.NestedConnection 41068 41068 118 128 4516
create.SimpleMutation 7 7 52 66 1
cypher-directive.TopLevelMutationDirective 1135 1135 24 24 1134
delete.SimpleDelete 19401 19401 186 194 1040
delete.NestedDeleteInUpdate 19165 19165 140 169 2040
2871.NestedRelationshipFilter 23093 23067 54 61 4433
2925.SingleRelationshipFilter 6468 6468 37 44 1040
2925.NestedSingleRelationshipFilter 22891 22891 72 111 2174
2925.SingleRelationshipRequiredFilter 5201 5201 31 41 1040
2925.NestedSingleRelationshipRequiredFilter 9361 9361 50 58 1040
query.SimpleQuery 3121 3121 18 21 1040
query.SimpleQueryWithRelationship 16129 16129 42 44 2174
query.QueryWhere 9675 9675 34 38 2162
query.SimpleQueryWithNestedWhere 9842 9842 54 51 2162
query.Nested 10095502 10095502 6694 6605 2008534
query.NestedWithFilter 10074351 10074351 6801 6732 2004000
query.OrFilterOnRelationships 41494 42844 136 169 1447
query.OrFilterOnRelationshipsAndNested 35187 36957 178 288 1447
query.QueryWithNestedIn 13654 13850 45 84 1312
query.NestedConnectionWhere 9801 9801 118 73 2174
query.DeeplyNestedConnectionWhere 9850 9912 72 109 2174
query.DeeplyNestedWithRelationshipFilters 18740 18800 127 223 1580
query.NestedWithRelationshipSingleFilters 3865 3865 183 180 1134
query.Fulltext 64 64 29 32 16
query.FulltextWithNestedQuery 558 558 39 51 84
sorting-and-cypher.TopLevelSortWithCypher 14059 14059 45 50 2174
sorting-and-cypher.TopLevelConnectionSortWithCypher 14059 14059 69 73 2174
sorting-and-cypher.TopLevelSortWithCypherWithNested 14174 14159 59 65 2174
sorting-and-cypher.TopLevelConnectionSortWithCypherWithNested 14174 14159 98 108 2174
sorting-and-cypher.TopLevelSortWithExpensiveCypher 14969 14827 95 118 2174
sorting-and-cypher.TopLevelConnectionSortWithExpensiveCypher 14592 14510 99 124 2174
sorting.SortMultipleTypes 3498 3498 79 93 1040
sorting.SortMultipleTypesWithCypherWithCypher 14437 14543 102 122 2174
sorting.SortOnNestedFields 14049 14049 52 53 2174
sorting.SortDeeplyNestedFields 43148 43148 72 108 4516
sorting.ConnectionWithSort 3281 3281 67 75 1040
unions.SimpleUnionQuery 321 321 53 91 35
unions.SimpleUnionQueryWithMissingFields 293 293 50 57 35
unions.NestedUnion 410637 410637 271 253 33033
unions.NestedUnionWithMissingFields 384611 384611 252 242 33033
update.NestedUpdate 16143 16143 91 109 2002

Old Schema Generation: 23.868s
Schema Generation: 24.634s
Old Subgraph Schema Generation: 27.178s
Subgraph Schema Generation: 28.085s

* Switch from `gql` to `/* GraphQL */` for TCK tests

* Remove from performance tests
import * as fs from "fs";
import gql from "graphql-tag";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'gql' is defined but never used. Allowed unused vars must match /^_/u.

@darrellwarde darrellwarde marked this pull request as ready for review February 23, 2024 11:45
@darrellwarde darrellwarde merged commit 1b7b75f into dev Feb 23, 2024
80 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
@MacondoExpress MacondoExpress deleted the 5.0.0 branch October 28, 2024 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Pull requests
Development

Successfully merging this pull request may close these issues.

7 participants