Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in the sda-svc helm chart #1419

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bugfix in the sda-svc helm chart #1419

wants to merge 3 commits into from

Conversation

jbygdell
Copy link
Collaborator

@jbygdell jbygdell commented Feb 19, 2025

Closes #1069

Description

This PR fixes some issues with the sda-svc chart

  • SCHEMA_TYPE is added to the list of ENVs for the API service so that it will work properly in any deployment scenario.
  • OIDC_CONFIGURATION_URL in the download service strips the / as the last character in the OIDC URL. This is to prevent a string concatenation error.

How to test

make k3d-create-cluster
make k3d-import-images
make k3d-deploy-dependencies
make k3d-deploy-postgres
make 3d-deploy-rabbitmq
make k3d-deploy-sda-s3

@jbygdell jbygdell self-assigned this Feb 19, 2025
@jbygdell
Copy link
Collaborator Author

Waiting for the chart bump to be merged

@jbygdell jbygdell marked this pull request as ready for review February 20, 2025 08:15
@jbygdell jbygdell requested a review from a team February 20, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts] fix url concatenation so we don't get // in the urls
1 participant