Adapting to Lastet Near Lake Framework #9
Conversation
bh2smith
commented
May 29, 2024
•
bh2smith
commented
- Drop CI python version to 3.11 (near lake framework doesn't work with 3.12)
- Load .env in Makefile
- [Minor] Fix enumeration in Readme
- 🔑 Adapt main file to use latest near-lake-framework
- Use >= on requirements file (also version bump near-lake-framework to 0.0.8)
- Add AWS env details to readme (closes Instructions Don't Mention Need for AWS Credentials #7)
| @@ -1,7 +1,7 @@ | |||
| asyncio==3.4.3 | |||
There was a problem hiding this comment.
I would also like to remove the strict == requirements in near-lake-framework (otherwise we can't really move to python 3.12 or beyond).
There was a problem hiding this comment.
hmm. I used the == because in case the package makes an update with breaking changes in the future, it's guaranteed to work with the specified version. But since that syntax won't work with future python versions, then we can change it to >=.
| toml==0.10.2 | ||
| asyncio>=3.4.3 | ||
| near-lake-framework>=0.0.8 | ||
| requests>=2.32.0 |
There was a problem hiding this comment.
This change also addresses dependabot alert: https://github.com/near/gas-station-event-indexer/security/dependabot/1
|
Thanks for your quick review. I made some more updates to the near-lake today as well, will circle back here tomorrow to add a few more improvements. |
