INC-14: Correct the label merge for ContainerWaiting alert
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the series used for merging the node label for the ContainerWaiting alert in Prometheus. The information is in the kube_pod_info, which is used in all other Alerts, whereas kube_node_info seems to have occasional duplicate values breaking the check.
jonathanio
added
priority/high
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the series used for merging the node label for the
ContainerWaitingalert in Prometheus. The information is in thekube_pod_info, which is used in all other Alerts, whereaskube_node_infoseems to have occasional duplicate values breaking the check.Checklist
Please check and confirm the following items have been performed, where
possible, for this Pull Request:
type/...,changes/..., and 'release/...' labels, as needed.