[#145] handle_insert_query 테스트 리팩토링 및 버그 수정, 테스트케이스 추가 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull reviewers statsStats of the last 14 days for rrdb:
|
|
✅ Total Coverage: 48.62% |
|
✅ Total Coverage: 48.85% |
|
✅ Total Coverage: 48.92% |
|
✅ Total Coverage: 48.92% |
|
✅ Total Coverage: 48.92% |
|
✅ Total Coverage: 49.01% |
|
✅ Total Coverage: 49.01% |
|
✅ Total Coverage: 49.01% |
|
✅ Total Coverage: 49.04% |
myyrakle
commented
Jul 31, 2024
| "E0408 expected ')'. but your input word is '{:?}'", | ||
| current_token | ||
| ))); | ||
| } |
There was a problem hiding this comment.
불필요한 지연처리 빼고 match절에서 즉시리턴
| @@ -23,6 +23,10 @@ impl Parser { | |||
| } | |||
|
|
|||
| // INTO 토큰 삼키기 | |||
| if !self.has_next_token() { | |||
| return Err(ParsingError::wrap("E0410 need more tokens")); | |||
| } | |||
| @@ -220,7 +214,7 @@ impl Parser { | |||
| } | |||
|
|
|||
| // 쉼표가 있으면 삼키기 | |||
| if self.pick_next_token() == Token::Comma { | |||
| if self.has_next_token() && self.pick_next_token() == Token::Comma { | |||
| self.get_next_token(); | |||
| } | |||
설명요거 없으시면 지워주세요 ㅎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #145
설명
테스트코드 추가