Avoid dynamic allocation #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….51_use_asm_macro
francis-starlab
force-pushed
the
avoid-dynamic-allocation
branch
from
01d00f5 to
c9fa2f4
Compare
francis-starlab
changed the title
francis-starlab
force-pushed
the
avoid-dynamic-allocation
branch
from
c9fa2f4 to
0209669
Compare
francis-starlab
changed the title
francis-starlab
changed the title
ALSchwalm
reviewed
Jan 23, 2021
ALSchwalm
requested changes
Jan 23, 2021
There was a problem hiding this comment.
Just some minor changes. The duplicate mapping is very strange and may be revealing an underlying bug. I'll need to dig in to it. I think it is going to block this, unfortunately, because if the double mapping is expected, we need to decide how to suppress all of those messages.
…const-usage Replace magic numbers with constants in linux.rs
…m_macro Resolve mythril-hypervisor#51, use new asm! macro
…id-allocation Avoid many instances of dynamic allocation
francis-starlab
force-pushed
the
avoid-dynamic-allocation
branch
from
ea2e514 to
411d660
Compare
|
Well that's annoying. Working on fixing that mess. |
francis-starlab
force-pushed
the
avoid-dynamic-allocation
branch
from
411d660 to
990de9d
Compare
francis-starlab
force-pushed
the
avoid-dynamic-allocation
branch
from
7cfc6b4 to
dc6423a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.