Use attribute keys suggested by official documentation for macOS #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the 'user' namespace is not really needed on Linux either. I don't remember where I got this from. It might have been recommended to distinguish from system attributes. Here is a(nother) list of supported attributes. Both seem fine. The new macOS attribute apparently hasn't been around when I implemented this in 2020. Thanks again for the PR! Very much appreciated. Crossing fingers the release GH actions still work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24.
usernamespace in macOS. I'm not sure though if it was needed in previous versions of macOS or with other filesystems, I'm using macOS Sonoma (current) with APFS filesystem (default) and have no access to any other combination. Maybe we should also set the namespaced attributes for the compatibility with some previous configurations, or maybe this was just never tested to work in macOS.com.dropbox.ignored, also setcom.apple.fileprovider.ignore#Pattribute, which seems to be used by the newer Dropbox versions (mentioned in dropbox help page for setting a file or folder to be ignored).