-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guidelines: add captions to verovio and listings for chapter 1–3 #1635
base: develop
Are you sure you want to change the base?
guidelines: add captions to verovio and listings for chapter 1–3 #1635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work. I noticed that some captions end with a full stop, others don't. It's a quite common practice to have none there (see https://www.stylemanual.gov.au/content-types/images/alt-text-captions-and-titles-images).
thanks for pointing to this. I also was wondering what might be the "most correct" way how to do this and found some discussions stating, a full stop should be added when it is a full sentence and not to add one when it is just a word or some single words but no complete sentence. i tried to do this in this kind of way. since duden says "Auch Bildunterschriften werden nicht mit Punkt versehen, vor allem wenn es sich nicht um vollständige Sätze handelt. Bestehen Bildunterschriften allerdings aus mehreren Sätzen, wird im Allgemeinen der Punkt gesetzt." and i am absolutely not attached to this full stop, despite there is more than one sentence, i can easily update the commit by deleting all of them. would that be a suggestion that makes most of us happy? |
this commit deletes full stops. full stops are only provided, if the caption contains more than one sentence. Refs music-encoding#1635
i did an update regarding full stop. i am happy to get two reviews |
@rettinghaus Is this good to go? |
source/docs/03-metadata.xml
Outdated
<egXML xmlns="http://www.tei-c.org/ns/Examples" rend="code" xml:space="preserve"><xi:include xmlns:xi="http://www.w3.org/2001/XInclude" href="../examples/header/header-sample089.txt" parse="text"/></egXML> | ||
</figure> | ||
</p> | ||
<p>A slightly more structured form would be:</p> | ||
<p> | ||
<figure> | ||
<head/> | ||
<head><gi scheme="MEI">addDesc</gi> with a little bit more structure</head> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<head><gi scheme="MEI">addDesc</gi> with a little bit more structure</head> | |
<head>Example of <gi scheme="MEI">addDesc</gi> with a little bit more structure</head> |
source/docs/03-metadata.xml
Outdated
<egXML xmlns="http://www.tei-c.org/ns/Examples" rend="code" xml:space="preserve"><xi:include xmlns:xi="http://www.w3.org/2001/XInclude" href="../examples/header/header-sample090.txt" parse="text"/></egXML> | ||
</figure> | ||
</p> | ||
<p>These transcriptions – as in the musical text – can also be marked by means of <gi scheme="MEI">add</gi>, <gi scheme="MEI">del</gi>, (see module MEI.edittrans) etc. (see <ptr target="#editTrans"/>) and assigned to a specific scribe by <att>hand</att> (see <gi scheme="MEI">handList</gi>):</p> | ||
<p> | ||
<figure> | ||
<head/> | ||
<head><gi scheme="MEI">addDesc</gi> with <gi scheme="MEI">add</gi> and <att>hand</att> attribute</head> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<head><gi scheme="MEI">addDesc</gi> with <gi scheme="MEI">add</gi> and <att>hand</att> attribute</head> | |
<head>Example of <gi scheme="MEI">addDesc</gi> with <gi scheme="MEI">add</gi> and <att>hand</att> attribute</head> |
source/docs/03-metadata.xml
Outdated
@@ -1844,7 +1844,7 @@ | |||
<p>The following example demonstrates how to structure detailed information about a repository (including the use of <gi scheme="MEI">identifier</gi>):</p> | |||
<p> | |||
<figure> | |||
<head/> | |||
<head><gi scheme="MEI">repository</gi></head> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<head><gi scheme="MEI">repository</gi></head> | |
<head>Example of <gi scheme="MEI">repository</gi></head> |
source/docs/03-metadata.xml
Outdated
@@ -1891,7 +1891,7 @@ | |||
<p>The <gi scheme="MEI">extMeta</gi> element may be contained by <gi scheme="MEI">expression</gi>, <gi scheme="MEI">item</gi>, <gi scheme="MEI">manifestation</gi>, <gi scheme="MEI">work</gi> and <gi scheme="MEI">meiHead</gi> elements. It may include text and any number of well-formed XML fragments, XML comments, and CDATA sections, except for MEI markup, which is prohibited. The document element of each fragment must explicitly declare its namespace.</p> | |||
<p> | |||
<figure> | |||
<head/> | |||
<head><gi scheme="MEI">extMeta</gi></head> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<head><gi scheme="MEI">extMeta</gi></head> | |
<head>Example of <gi scheme="MEI">extMeta</gi></head> |
source/docs/03-metadata.xml
Outdated
@@ -1945,7 +1945,7 @@ | |||
<p>The <gi scheme="MEI">meiCorpus</gi> element is intended for the encoding of corpora, though it may also be useful in encoding any collection of disparate materials. The individual samples in the corpus are encoded as separate <gi scheme="MEI">mei</gi> elements, and the entire corpus is enclosed in an <gi scheme="MEI">meiCorpus</gi> element. Each sample has the usual structure for a <gi scheme="MEI">mei</gi> document, comprising an <gi scheme="MEI">meiHead</gi> followed by a <gi scheme="MEI">music</gi> element. The corpus, too, has a corpus-level <gi scheme="MEI">meiHead</gi> element, in which the corpus as a whole, and encoding practices common to multiple samples may be described. The overall structure of an MEI-conformant corpus is thus:</p> | |||
<p> | |||
<figure> | |||
<head/> | |||
<head><gi scheme="MEI">meiCorpus</gi></head> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<head><gi scheme="MEI">meiCorpus</gi></head> | |
<head>Example of <gi scheme="MEI">meiCorpus</gi></head> |
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
thanks for your reviews, i accepted all suggestions and i am happy if you merge this PR :) |
this PR adds missing captions to all listings for chapter 1–3
Refs #1217