Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Gemfile.lock to latest bundler #750

Merged

Conversation

musicEnfanthen
Copy link
Member

This PR updates the Gemfile.lock to use the latest bundler and MINGW64 environments for windows.

@bwbohl bwbohl merged commit 3c0e306 into music-encoding:main Feb 12, 2025
@craigsapp
Copy link
Member

For my GitHub Pages website, I include the Gemfile, but exclude the Gemfile.lock file. GitHub seems to automatically generate Gemfile.lock when creating the websites, and therefore I never need to update Gemfile.lock since GitHub generates it on the fly when preparing the website.

@ahankinson
Copy link
Member

ahankinson commented Feb 12, 2025

The lock file contains the specific version used to build the site and should be checked into version control since it should be a known good build. The Gemfile itself only contains a range of versions. You really need both to ensure everyone is building on the same set of dependencies, particularly because some Ruby devs love to break things in minor and patch versions. 🤓

@craigsapp
Copy link
Member

I have never had a problem.

@musicEnfanthen
Copy link
Member Author

Thank you.

I agree with @ahankinson that, when having more than one developer contributing to a GH pages website, the .lock file is needed to ensure a controlled environment.
It may not be needed for creating and deploying the page on GH, snce GH will resolve it correctly, but when it comes to building it locally on many different developers' architectures and systems, we will more likely run into some kind of version-related conflicts sooner or later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants