fix: gp5 voltas import #24981
fix: gp5 voltas import #24981
Conversation
|
That It doesn't make sense though, and the failing unit test seems to prove it. There there repeat cound would need to be much higher, 8, as there are that many voltas (ignoring the missing of a volta for the 4th, 5th and 7th round) a 2 is actually enough there, but that last measure neeeds a play count of at least 4 and an end repeat barline. |
mikekirin
force-pushed
the
gp5-voltas-import-m
branch
from
965203a to
1e6a445
Compare
|
play count needs to be one more that the 1st volta's repeat list length... here (in that unit test) a 2, the default, is perfectly correct |
Backport of musescore#24981 and fix some clazy warnings, one of which revealed a memory leak
All this actually makes sense only if Volta bar needs to play more than once. Otherwise, the default behavior when Volta bar plays only once, this parameter does nothing. |
Backport of musescore#24981 and fix some clazy warnings, one of which revealed a memory leak
* master: fix: gp5 voltas import (musescore#24981) Fix switching voices from the middle of a tuplet Make entering a rest switch to input mode Don't attach grace notes aftrer to time tick segment Fix voice too long corruption Update musescore font file and add new filled playhead icon Add playhead icon Updated MusescoreIcon.ttf file Run `lupdate` with arguments `-no-obsolete` Update in-repo translations from Transifex Simplify FocusableControl.qml by removing unnecessary content wrapper Fix musescore#24723: Honor --score-transpose flag in CLI
Measure with the end repeat barline must have a Play count value that is equal to, the total number of times of playback of this measure + 1 or morehttps://musescore.org/en/handbook/4/voltas#change-playback