-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4.3] Added image and actions to musesound update spec #24974
[4.4.3] Added image and actions to musesound update spec #24974
Conversation
7bbfebc
to
3d75c28
Compare
@@ -45,7 +44,7 @@ class IMuseSoundsCheckUpdateService : MODULE_EXPORT_INTERFACE | |||
|
|||
virtual Progress updateProgress() = 0; | |||
|
|||
virtual void openMuseHub() = 0; | |||
virtual void openMuseHub(const std::vector<std::string>& actions) = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we need it in this interface... Perhaps it was originally intended to be reusable, but with the addition of the actions argument, it's unclear how to use it. We can make it a private method of MuseSoundsCheckUpdateScenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -78,7 +80,7 @@ StyledDialogView { | |||
Layout.fillWidth: true | |||
Layout.preferredHeight: 186 | |||
|
|||
source: "qrc:/qml/Muse/Update/resources/muse_sounds_promo.png" | |||
//source: "qrc:/qml/Muse/Update/resources/muse_sounds_promo.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
010a006
to
b4c8006
Compare
b4c8006
to
2e78418
Compare
New spec