Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pedal import/export for MusicXML #20224

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

rettinghaus
Copy link
Contributor

This PR contains only the fixes to MusicXML import/export from #20219.

@cbjeukendrup cbjeukendrup merged commit 7d2cae5 into musescore:4.2.0 Dec 4, 2023
@rettinghaus rettinghaus deleted the fix/pedal branch December 4, 2023 11:15
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Dec 10, 2023

Seems something is wrong with this PR (and its counterpart for master too):
Take the attached score,
image
export to MusicXML (attached too), import in Mu3 (the official way from Mu4 back to Mu3), gives:

Fatal error: line 108 column 73 Content of attribute type does not match its type definition: String content is not listed in the enumeration facet..

      <direction placement="below">
        <direction-type>
          <pedal type="resume" line="yes" sign="yes" default-y="-65.00"/>
          </direction-type>
        </direction>

It is the type="resume" it complains about
pedal.zip

Mu 4.1.1 doesn't complain, but screws up on import quite badly:
image

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Dec 10, 2023

Might not be related to this PR, as the issue exists with 4.2.0 Beta already, which IMHO is older than this PR's merge into the 4.2.0 branch?
Anyway, I've opened issue #20395 for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants