-
-
Notifications
You must be signed in to change notification settings - Fork 110
[docs][Slider] Add range slider example #1600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][Slider] Add range slider example #1600
Conversation
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
Good find, it is now ~ I've opened an issue: #1602 |
So, is it that this PR should not be merged until the issue is fixed? |
|
docs/src/app/(public)/(content)/react/components/slider/page.mdx
Outdated
Show resolved
Hide resolved
I think it's ok, I suggested a copy change CC @colmtuite to have a look and for a additional review 🙏 |
Co-authored-by: Albert Yu <albert@albertyu.co> Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
@colmtuite Can you review? |
Just took a look. The thumbs can still be dragged past each other? @ZeeshanTamboli @mj12albert |
@colmtuite I merged master, the demo should work now: https://deploy-preview-1600--base-ui.netlify.app/react/components/slider#examples |
@mj12albert it's possible to get into a state where you can no longer drag the min thumb when there's no Screen.Recording.2025-04-16.at.11.27.00.am.mov |
We do set But this reminds me we should consider defaulting this to |
Closes #1527
Preview: https://deploy-preview-1600--base-ui.netlify.app/react/components/slider#examples