Skip to content

[docs][Slider] Add range slider example #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Mar 24, 2025

@ZeeshanTamboli ZeeshanTamboli added component: slider This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Mar 24, 2025
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 433262d
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/68009fd20fe8e6000871e793
😎 Deploy Preview https://deploy-preview-1600--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review March 24, 2025 10:04
@ZeeshanTamboli ZeeshanTamboli changed the title [Slider] Add range slider example [docs][Slider] Add range slider example Mar 24, 2025
@atomiks

This comment was marked as resolved.

@mj12albert
Copy link
Member

but is this is this issue known

Good find, it is now ~ I've opened an issue: #1602

@ZeeshanTamboli
Copy link
Member Author

So, is it that this PR should not be merged until the issue is fixed?

@ZeeshanTamboli
Copy link
Member Author

So, is it that this PR should not be merged until the issue is fixed?

@mj12albert ?

@mj12albert
Copy link
Member

So, is it that this PR should not be merged until the issue is fixed?

I think it's ok, I suggested a copy change

CC @colmtuite to have a look and for a additional review 🙏

Co-authored-by: Albert Yu <albert@albertyu.co>
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
@ZeeshanTamboli
Copy link
Member Author

@colmtuite Can you review?

@colmtuite
Copy link
Contributor

colmtuite commented Apr 15, 2025

Just took a look. The thumbs can still be dragged past each other? @ZeeshanTamboli @mj12albert

@mj12albert
Copy link
Member

@atomiks
Copy link
Contributor

atomiks commented Apr 16, 2025

@mj12albert it's possible to get into a state where you can no longer drag the min thumb when there's no minStepsBetweenValues. Not sure if z-index is handled automatically or if this is up to the user in the docs here

Screen.Recording.2025-04-16.at.11.27.00.am.mov

@mj12albert
Copy link
Member

We do set pointer-events and z-index on the thumb (here), I'll need to check if this can be worked around

But this reminds me we should consider defaulting this to 1

@mj12albert mj12albert merged commit 31df0eb into mui:master Apr 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs][slider] Add range slider example
4 participants