Fix intermittent issue with model card title and description labels #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue where the title or description of some models in the main listing were not visible. The root problem was we were using similar identifiers for the title and description labels in ModelCard and ModelCardViewAllModal widgets (which is a nested view under the model card view). The solution is to use unique identifiers, so the widget lookup retrieves what we expect in each case..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204
There was an issue where the title or description of some models in the main listing were not visible. The root problem was we were using similar identifiers for the title and description labels in
ModelCardandModelCardViewAllModalwidgets (which is a nested view under the model card view).The solution is to remove the ambiguity by providing unique identifiers for the labels into the modal widget, so the widget lookup for the labels is what we expect in each case.