Support packaging on Windows via a Rust program that implements before-packaging commands #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Supports both `before-packaging-command` and `before-each-package-command` Note: nothing is tested yet
installation of WasmEdge or special cases for packaging of WasmEdge into the .exe or .msi. --> still need to re-test macOS and Linux
Includes auto-installation of WasmEdge if it cannot be found; installation is performed via a PowerShell script that follows the Windows WasmEdge installation instructions in the README (downloading WasmEdge files from the GitHub releases page).
The main binary needs the location of the main `wasmedge.dll` to be on the system PATH, otherwise it fails to load. Still having some trouble with MAKEPAD_PACKAGE_DIR, that is, Makepad cannot properly find the resources bundled with the app.
Cleanup verbose output in moxin-runner
|
ok this now works on Windows, but I haven't tested the merged logic that was reimplemented for macOS and Linux. So, still not ready to merge in. |
WasmEdge on Windows requires a CPU with AVX512 support, so the `moxin-runner` app now explicitly checks for that and throws an error if unsupported, and then terminates the process.
Merged
kevinaboos
changed the title
|
everything ready to go! |
these are no longer used and were replaced by the `before-packaging-command` rust program
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before-packaging-commandandbefore-each-package-commandbefore-packaging-commandRust programNote: nothing is tested yetAll three platforms tested and working. Release candidate packages are available here: https://drive.google.com/drive/folders/165o98vJU_VCB8uVc_B2fD6uGzJtJx4v7?usp=drive_link