ES-1690 adding sunbird authentication plugin #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Rana <sacrana324@gmail.com>
ase-101
reviewed
Oct 6, 2024
ase-101
reviewed
Oct 6, 2024
ase-101
reviewed
Oct 6, 2024
ase-101
reviewed
Oct 6, 2024
ase-101
reviewed
Oct 6, 2024
...ntegration-impl/src/main/java/io/mosip/esignet/sunbirdrc/integration/dto/ReCaptchaError.java
Outdated
Show resolved
Hide resolved
ase-101
reviewed
Oct 6, 2024
...gration-impl/src/main/java/io/mosip/esignet/sunbirdrc/integration/dto/ReCaptchaResponse.java
Outdated
Show resolved
Hide resolved
ase-101
reviewed
Oct 6, 2024
...esignet-integration-impl/postman-collections/eSignet-with-Sunbird-RC.postman_collection.json
Outdated
Show resolved
Hide resolved
ase-101
reviewed
Oct 6, 2024
ase-101
reviewed
Oct 6, 2024
ase-101
reviewed
Oct 6, 2024
ase-101
reviewed
Oct 6, 2024
ase-101
reviewed
Oct 6, 2024
...main/java/io/mosip/esignet/sunbirdrc/integration/service/SunbirdRCAuthenticationService.java
Outdated
Show resolved
Hide resolved
|
Hi @ase-101 I need some input on some of the changes you want me to make. Please check the comments. |
Signed-off-by: Sachin Rana <sacrana324@gmail.com>
Signed-off-by: Sachin Rana <sacrana324@gmail.com>
ase-101
approved these changes
Oct 18, 2024
zesu22
pushed a commit
to Infosys/esignet-plugins
that referenced
this pull request
Nov 25, 2024
* ES-1690 adding sunbird authentication plugin Signed-off-by: Sachin Rana <sacrana324@gmail.com> * addressed review comments Signed-off-by: Sachin Rana <sacrana324@gmail.com> * property 'kba' changed to 'kbi' Signed-off-by: Sachin Rana <sacrana324@gmail.com> --------- Signed-off-by: Sachin Rana <sacrana324@gmail.com>
zesu22
pushed a commit
to Infosys/esignet-plugins
that referenced
this pull request
Nov 25, 2024
* ES-1690 adding sunbird authentication plugin Signed-off-by: Sachin Rana <sacrana324@gmail.com> * addressed review comments Signed-off-by: Sachin Rana <sacrana324@gmail.com> * property 'kba' changed to 'kbi' Signed-off-by: Sachin Rana <sacrana324@gmail.com> --------- Signed-off-by: Sachin Rana <sacrana324@gmail.com>
zesu22
pushed a commit
to Infosys/esignet-plugins
that referenced
this pull request
Nov 25, 2024
* ES-1690 adding sunbird authentication plugin Signed-off-by: Sachin Rana <sacrana324@gmail.com> * addressed review comments Signed-off-by: Sachin Rana <sacrana324@gmail.com> * property 'kba' changed to 'kbi' Signed-off-by: Sachin Rana <sacrana324@gmail.com> --------- Signed-off-by: Sachin Rana <sacrana324@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>
ase-101
added a commit
that referenced
this pull request
Dec 1, 2024
* ES-1638 ES-1639 (#31) * Removed VCI related classes and added application.properties Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> * Removed VCI related dependency Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> --------- Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [ES-593] added authTransactionId in the log description (#33) Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * Made changes to use Resource instead of Resttemplate to support classpath, http protocol (#34) Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * ES-1638 (#35) Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [ES-1148] updated the error mesaage and property (#36) Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * ES-842 Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * ES-842 updated the pwd and kbi format Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [ES-842] modified the validate method (#38) Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [ES-842] modified framesPerSecond (#39) Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [ES=1148] modified the error message (#40) Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * updated readme and config comments Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [ES-1613] added test case for coverage (#27) * added test case for coverage Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> * remvoed null pointer bug Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> * removed bug Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> * review comment changes Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> * review changes Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> * review changes Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> * review changes Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> * reivew changes Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> --------- Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> Co-authored-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * Updated readme and updated version Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * Removed VCI related classes Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * Corrected get-identity endpoint url Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [ES-1613] Added test cases for coverage (#51) * [ES-1613] Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> * [ES-1613] Reviewed comments Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> * [ES-1613] Added test cases Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> * reviewed comments[ES-1618] Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> --------- Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * Added extra loggers Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * Added test cases Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * Added test cases Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * Updated readme document Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * Added idrepo get-identity endpoint support Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * Added idrepo get-identity endpoint support Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * updated the version form 1.3.0 to 1.3.1 (#48) * update the version form 1.3.0 to 1.3.1 Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> * version update Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> --------- Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> Co-authored-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * [ES-1613] (#50) Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * ES-1690 adding sunbird authentication plugin (#47) * ES-1690 adding sunbird authentication plugin Signed-off-by: Sachin Rana <sacrana324@gmail.com> * addressed review comments Signed-off-by: Sachin Rana <sacrana324@gmail.com> * property 'kba' changed to 'kbi' Signed-off-by: Sachin Rana <sacrana324@gmail.com> --------- Signed-off-by: Sachin Rana <sacrana324@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * Feature ES-1100 Integration with API - v2 kyc-auth endpoint to give out claim verification details (#49) * ES-1100 API integration kyc-auth v2 Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com> * cherry-pick Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com> * addressed review comments Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com> * removed commented code Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com> * fixed test case Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com> * addressed review comments Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com> --------- Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * corrected import statement (#61) Signed-off-by: Sachin Rana <sacrana324@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> * added extra test cases to cover uncover conditions (#55) Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> Co-authored-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> --------- Signed-off-by: ase-101 <sunkadaeanusha@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> Signed-off-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Signed-off-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> Signed-off-by: Sachin Rana <sacrana324@gmail.com> Signed-off-by: Md-Humair-KK <mdhumair.kankudti@gmail.com> Signed-off-by: Zeeshan Mehboob <82993262+zesu22@users.noreply.github.com> Co-authored-by: ase-101 <sunkadaeanusha@gmail.com> Co-authored-by: pvsaidurga <132046494+pvsaidurga@users.noreply.github.com> Co-authored-by: Kaif Siddique <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <mohdkaif.siddique@ad.infosys.com> Co-authored-by: sacrana0 <sacrana324@gmail.com> Co-authored-by: Md Humair Kankudti <163233654+Md-Humair-KK@users.noreply.github.com>
pvsaidurga
pushed a commit
to Infosys/esignet-plugins
that referenced
this pull request
Jan 15, 2025
* ES-1690 adding sunbird authentication plugin Signed-off-by: Sachin Rana <sacrana324@gmail.com> * addressed review comments Signed-off-by: Sachin Rana <sacrana324@gmail.com> * property 'kba' changed to 'kbi' Signed-off-by: Sachin Rana <sacrana324@gmail.com> --------- Signed-off-by: Sachin Rana <sacrana324@gmail.com>
zesu22
pushed a commit
to Infosys/esignet-plugins
that referenced
this pull request
Jan 30, 2025
* ES-1690 adding sunbird authentication plugin Signed-off-by: Sachin Rana <sacrana324@gmail.com> * addressed review comments Signed-off-by: Sachin Rana <sacrana324@gmail.com> * property 'kba' changed to 'kbi' Signed-off-by: Sachin Rana <sacrana324@gmail.com> --------- Signed-off-by: Sachin Rana <sacrana324@gmail.com> Signed-off-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.