feat(VaultUtils): add accruedInterest util #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested changes
Jan 28, 2025
| toAssets( | ||
| totalSupply, | ||
| { totalAssets: 0n, totalSupply: 0n, decimalsOffset }, | ||
| "Down", |
There was a problem hiding this comment.
Suggested change
| "Down", |
Optional: this is the default behavior and it sematnically corresponds to what's expected: the canonical assets value of all shares
| @@ -293,6 +294,13 @@ export class AccrualVault extends Vault implements IAccrualVault { | |||
| return MathLib.wMulDown(this.apy, MathLib.WAD - this.fee); | |||
| } | |||
|
|
|||
| /** | |||
| * Total interest paid by borrowers, increased with unrealized bad debt. | |||
There was a problem hiding this comment.
Suggested change
| * Total interest paid by borrowers, increased with unrealized bad debt. | |
| * Total interest paid by borrowers to this vault plus unrealized bad debt. | |
| * In the case of MetaMorphoV1.1 vaults, also contains realized bad debt. |
Or we pass totalAssets - lostAssets to accruedInterest
|
Formula is wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of INTER-1822
This PR implements the util to compute accruedInterests on a vault, given it's current state