Share price decrease on forced removal #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhusson
changed the title
MathisGD
reviewed
Aug 16, 2024
QGarchery
reviewed
Aug 16, 2024
There was a problem hiding this comment.
This has the drawback of making it possible for allocators to bypass the increase of the lostAssets variable: they can call updateWithdrawQueue to "realize the bad debt on the vault" (without actually changing the withdraw queue). Essentially, there is the vault short issue where allocators can make the share price go down atomically, which might be giving too much power to allocators
|
Closing due to message above + less simple accounting. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a market is force-removed, share price is decreased and lost assets stay constant.
May need certora update.