PYTHON-4965 - Consolidate startup and teardown tasks #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
force-pushed
the
PYTHON-4965
branch
from
f4b9fad to
9cd3a61
Compare
Jibola
previously approved these changes
Nov 26, 2024
| @@ -1640,6 +1594,7 @@ tasks: | |||
| params: | |||
| binary: bash | |||
| working_dir: src | |||
| include_expansions_in_env: ["PYTHON_BINARY"] | |||
There was a problem hiding this comment.
Is this a bug you caught during the fix?
There was a problem hiding this comment.
We need to pass this explicitly where needed now to use the correct Python binary. Part of our later work will be to unify the use of PYTHON_BINARY to remove the need to pass it explicitly.
|
Docker teardown is handled in drivers-evergreen-tools. I'd suggest a single teardown script that runs the appropriate drivers-evergreen-tools teardowns: https://github.com/mongodb/mongo-go-driver/blob/master/.evergreen/config.yml#L143 |
|
.evergreen/scripts/teardown-docker.sh can be removed now. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.