-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-37133: Collections in Mixed data type #715
DOCSP-37133: Collections in Mixed data type #715
Conversation
c2ac2d6
to
b219945
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me! Ill let Niharika give the official 👍 though as she is leading the project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@niharika01 this PR includes some unrelated updates (formatting cleanup and corrections I made while I was working in these pages), so not everything will need your review. I've left comments to indicate the updates specific to collections in mixed project that I'd like you to take a look at.
e277506
to
d9ff60c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small things!
Larger question: Should the 'Realm Object Schema' be referred to as 'Atlas Device SDK Object Schema'? I see you switch between using the terms depending on the page; should probably be standardized.
Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM, and thanks for making these updates!
Not sure why some of the :manual:
links are giving 404s on my end. If it's working on your end, perhaps just do a quick check to make sure they're working once deployed.
f24d5c6
to
072a715
Compare
072a715
to
22c8874
Compare
@@ -0,0 +1,23 @@ | |||
.. note:: Collections in Mixed fields supported in Apps created after May 22, 2024 | |||
|
|||
App Services Apps created *after* May 22, 2024 can store collections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating this! I think technically this was out in prod on May 29th but I'll defer to @tkaye407 since May 22nd was the official release date
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/atlas-app-services/master/ 🪵 Logs |
* Initial draft * Fix formatting * Fix broken link * Update to reference 'document' * Update note * Fix list formatting * Apply review feedback * Apply suggestions from code review Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com> * Update with date of app support * Update supported SDK versions * Add finalized date to note * Update source/sync/data-model/data-model-map.txt * Update source/schemas/relationships.txt --------- Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
Pull Request Info
Jira ticket: https://jira.mongodb.org/browse/DOCSP-37133
Misc formatting & style updates:
Reminder Checklist
Before merging your PR, make sure to check a few things.
Release Notes
Device Sync
Define a Data Model
Technical Details
Review Guidelines
REVIEWING.md