feat(action): introduce ecs task definition deploy action #17
Conversation
| if allow_empty and not active_task_definitions: | ||
| return "" |
There was a problem hiding this comment.
Can you explain your reasoning for allow_empty? It seems you are setting it to true in the action. Naively, I would think that not finding exactly one active task definition with the tag should always be an exception.
There was a problem hiding this comment.
The first time a deployment is made
The script will fail because at that time there wont be a task definition with the tag created_by: Github Actions Deployment
So the script needs to configurably allow for empty result, by default it's False
|
We have merged https://github.com/moneymeets/moneymeets-pulumi/pull/545 and moneymeets/action-ecs-deploy#1 I think the pull request here can be closed, @IamAbbey. |
|
@IamAbbey, do you still need the branch? If not, please also delete. Thanks! |
This action will be used in our deploy workflow