chore(pyclient): updated GraphQL metadata query to be in line with current metadata model #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lSchemaFieldFactory
|
mswertz
approved these changes
Jan 21, 2025
| @@ -167,8 +167,6 @@ def list_schema_meta(): | |||
| value | |||
| } | |||
| id | |||
| schemaName | |||
There was a problem hiding this comment.
ah, sorry! this is my bad. Should have made this a breaking change right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did
In #4586 the attributes
schemaNameandschemaIdwere removed from the MolgenisTableType in the GraphqlSchemaFieldFactory.These attributes were still present in the GraphQL query for retrieving a schema's metadata.
Posting this query to the latest versions of EMX2 causes errors as these attributes cannot be found.
This PR fixes this issue and makes the query in line with the schemas built by the backend.
How to test
list_schema_metain graphq_queries.py and paste it in the Graphql playground on the catalogue-demo schema on the test serverChecklist