Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data: new dashboard data model #4613

Merged
merged 3 commits into from
Jan 21, 2025
Merged

data: new dashboard data model #4613

merged 3 commits into from
Jan 21, 2025

Conversation

davidruvolo51
Copy link
Contributor

@davidruvolo51 davidruvolo51 commented Jan 17, 2025 •
edited
Loading

What are the main changes you did

This PR introduces the new version of the ERN_DASHBOARD template. This model is easier to use with the visualisation components and vue applications. It also gives more control to the users as configuring charts can now be made in the normal table viewer rather than in the vue application.

  • add new schema: ui_dashboards
  • added ontologies
  • added demo data
  • added documentation

How to test

  • Navigate to the preview or checkout the branch locally
  • Sign in as admin
  • Create a new schema using the UI_DASHBOARDS template and load the demo data.

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@davidruvolo51 davidruvolo51 self-assigned this Jan 17, 2025
@davidruvolo51 davidruvolo51 marked this pull request as ready for review January 17, 2025 14:57
mswertz
mswertz requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To pass the sonar please add a junit test that loads the demo data (like we do with all profiles). Then you can be sure it always works?

data/ui_dashboards/demodata/Chart data.csv Outdated Show resolved Hide resolved
data/ui_dashboards/molgenis.csv Show resolved Hide resolved
data/ui_dashboards/ontologies/Chart types.csv Show resolved Hide resolved
data/ui_dashboards/molgenis.csv Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
76.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@davidruvolo51 davidruvolo51 requested a review from mswertz January 21, 2025 10:54
@davidruvolo51 davidruvolo51 merged commit 1adb76e into master Jan 21, 2025
6 of 7 checks passed
@davidruvolo51 davidruvolo51 deleted the data/new-dashboard-schema branch January 21, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz approved these changes

Assignees

@davidruvolo51 davidruvolo51

Labels
data-model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidruvolo51 @mswertz