-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lightbug_http v0.1.15 #37
base: main
Are you sure you want to change the base?
Conversation
Since we have many different test files I've tried adding tests from source, not from the recipe in |
Also 0.1.6 is only going out later today / early tomorrow, thought I'd submit this in advance. Will let y'all know here when it's ready 🙏 |
Done, 0.1.6 is out! |
Actually, just shipped a hotfix at 0.1.7. Updated the version in the recipe. |
@saviorand Apologies for the delayed response! For now, if you don't mind including the tests in this PR too, that would be great. We're asking folks to include the tests in this repo so that we can automatically run the tests after your package builds. I realize this is a bit of a pain though, and I'm looking into alternative solutions for the long run. |
@carolinefrasca no problem at all, but I'm wondering if I can include multiple test files? Or does it all have to be in one big file |
@saviorand You can definitely include multiple test files! Check out mojmelo for an example of how to structure the recipe file – the test files were just included in a |
@carolinefrasca done! let me know if there's anything else i should tweak |
Hi @saviorand, it looks like the linter is finding trailing whitespace in your README – however, we're actually dropping the requirement to include a README in the PR, as long as your package's repo has a README (and yours does) – so the easiest way to resolve this error is probably to just delete the README from this PR, if that's okay with you? |
@carolinefrasca yes, that works, thanks! |
Perfect – are you able to remove the file from the PR? |
@carolinefrasca done! |
Thank you @saviorand! Unfortunately we're still seeing an error – I believe the build script just needs to be updated to: |
@carolinefrasca done, could you trigger the pipeline again? |
A quick update for everyone with open PRs that will hopefully make this process a bit easier: it's actually not necessary to include your test file(s) in the PR if you'd like to keep them in your source repo instead, as long as you include the test invocation and SHA/ID for your GitHub in the recipe file (here's an example with @TilliFe's Endia). Please let me know if you have any questions! |
@carolinefrasca not sure what's the difference between this recipe in Endia and the current version in this PR? |
@carolinefrasca actually I'm realizing now that the small-time import doesn't work with a hyphen when imported from Mojo code? I'm not sure if this is allowed, e.g. when I write I get an error:
if I use double quotes, I get a different error:
Same with single quotes. |
Ah you're right about the import – I'm going to have to re-add it using an underscore. I'll update you when it's done. |
Okay @saviorand, I think I've fixed it. It should be |
@carolinefrasca bumped the version to 0.1.11, could you start the pipeline? Thanks! |
Thanks! Not sure what this new error is caused by. Will investigate |
recipes/lightbug_http/recipe.yaml
Outdated
requirements: | ||
run: | ||
- max =24.6 | ||
- small_time =0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried adding this, maybe this helps?
@carolinefrasca adjusted something in the recipe, not sure if this will help though |
One thing I noticed is that you're using |
@carolinefrasca just fixed that! Thanks for flagging |
@carolinefrasca could I ask you to trigger the pipeline again? just noticed the recipe had an older MAX version set |
Just bumped the version again! Looks like the recipe was wrong on the main branch, maybe that was causing the issue. 🤞 |
Checklist
0
(for new packages, or if the version changed)