Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for infrared. #31

Merged
merged 9 commits into from
Jan 24, 2025
Merged

Add recipe for infrared. #31

merged 9 commits into from
Jan 24, 2025

Conversation

helehex
Copy link
Contributor

@helehex helehex commented Dec 11, 2024

No description provided.

@owenhilyard
Copy link

You're missing the CodeQL badge

@helehex
Copy link
Contributor Author

helehex commented Dec 12, 2024

Good catch, I tried it out and noticed it doesn't actually do anything for pure mojo code, so even if I add it, the badge doesn't show up right. I could still add it if necessary though.

If you want to see what I mean, I have a branch where I added the badge. (Also, CodeQL is enabled for the repo regardless of the badge)

@carolinefrasca
Copy link
Collaborator

Hey @helehex, good point on the pure Mojo part. Maybe we can just adjust this requirement to only be for packages that contain Python or other languages. The intention with the badge is just to provide a way for reviewers to tell that your repo has CodeQL enabled – is there another way to do that? I might've missed it.

@carolinefrasca
Copy link
Collaborator

@helehex looks like there is a little bit of trailing whitespace in your README - do you mind fixing so the pre-commit workflow won't complain?

Signed-off-by: helehex <helehex@gmail.com>
@carolinefrasca
Copy link
Collaborator

carolinefrasca commented Dec 16, 2024

Looking at this more, I think the fix is simple – line 15 of the recipe.yaml file just needs to be updated to: mojo package infrared -o ${{ PREFIX }}/lib/mojo/infrared.mojopkg

@yetalit
Copy link
Contributor

yetalit commented Jan 9, 2025

@helehex if having the main folder of your package named as src but importing the library by the name of the package file (infrared) doesn't cause any problem, then the only issue is that the test env used max 24.6 for running the test: https://github.com/modular/modular-community/actions/runs/12321698072/job/34497056955?pr=31#step:4:308
(│ │ │ │ max ┆ 24.6.0 ┆ release ┆ max ┆ 9.62 KiB │)
You should limit the max version for your project.

@carolinefrasca
Copy link
Collaborator

A quick update for everyone with open PRs that will hopefully make this process a bit easier: it's actually not necessary to include your test file(s) in the PR if you'd like to keep them in your source repo instead, as long as you include the test invocation and SHA/ID for your GitHub in the recipe file (here's an example with @TilliFe's Endia). Please let me know if you have any questions!

@carolinefrasca carolinefrasca merged commit a3f2fab into modular:main Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants