-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for infrared. #31
Conversation
You're missing the CodeQL badge |
Good catch, I tried it out and noticed it doesn't actually do anything for pure mojo code, so even if I add it, the badge doesn't show up right. I could still add it if necessary though. If you want to see what I mean, I have a branch where I added the badge. (Also, CodeQL is enabled for the repo regardless of the badge) |
Hey @helehex, good point on the pure Mojo part. Maybe we can just adjust this requirement to only be for packages that contain Python or other languages. The intention with the badge is just to provide a way for reviewers to tell that your repo has CodeQL enabled – is there another way to do that? I might've missed it. |
@helehex looks like there is a little bit of trailing whitespace in your README - do you mind fixing so the pre-commit workflow won't complain? |
Signed-off-by: helehex <helehex@gmail.com>
Looking at this more, I think the fix is simple – line 15 of the |
@helehex if having the main folder of your package named as |
A quick update for everyone with open PRs that will hopefully make this process a bit easier: it's actually not necessary to include your test file(s) in the PR if you'd like to keep them in your source repo instead, as long as you include the test invocation and SHA/ID for your GitHub in the recipe file (here's an example with @TilliFe's Endia). Please let me know if you have any questions! |
No description provided.