[stdlib] Consistently use Indexer in LinkedList
#3990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgreni
force-pushed
the
use-indexer-in-linkedlist
branch
4 times, most recently
from
d5b19f3 to
f4ef563
Compare
soraros
reviewed
Feb 10, 2025
bgreni
force-pushed
the
use-indexer-in-linkedlist
branch
2 times, most recently
from
37fea90 to
34ca2b4
Compare
soraros
reviewed
Feb 11, 2025
bgreni
force-pushed
the
use-indexer-in-linkedlist
branch
from
34ca2b4 to
3aafdb7
Compare
Signed-off-by: Brian Grenier <grenierb96@gmail.com>
Co-authored-by: soraros <soraros@users.noreply.github.com> Signed-off-by: bgreni <42788181+bgreni@users.noreply.github.com>
bgreni
force-pushed
the
use-indexer-in-linkedlist
branch
from
3aafdb7 to
bdf8e80
Compare
|
!sync |
modularbot
added
the
imported-internally
jackos
changed the title
Indexer in LinkedList`Indexer in LinkedList
|
!sync |
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
|
Landed in ddddf01! Thank you for your contribution 🎉 |
modularbot
pushed a commit
that referenced
this pull request
Feb 15, 2025
[External] [stdlib] Consistently use `Indexer` in `LinkedList` Use `Indexer` in all appropriate locations in `LinkedList` for consistency. Co-authored-by: bgreni <42788181+bgreni@users.noreply.github.com> Closes #3990 MODULAR_ORIG_COMMIT_REV_ID: 414230e1163eab1e961bece26ab395bef8b3904c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Indexerin all appropriate locations inLinkedListfor consistency.