do not leave dangling pointers

mmomtchev · Jan 17, 2025 · ed1450e · ed1450e
1 parent 458f8f6
commit ed1450e
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/objstore.cc b/src/objstore.cc
@@ -51,6 +51,8 @@ Value PyObjectWrap::New(Napi::Env env, PyStrongRef &&obj) {
     // Retrieve the existing object from the store
     VERBOSE_PYOBJ(OBJS, *obj, "Objstore retrieve");
     js = it->second->Value();
+    // Do not forget to invalidate the passed reference
+    obj = nullptr;
   }
 
   return js;