Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward ref select autocomplete field #275

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

Quis90
Copy link
Contributor

@Quis90 Quis90 commented Jul 10, 2024

No description provided.

Christian Seidel added 2 commits July 8, 2024 14:27
…Field.tsx
@Quis90 Quis90 requested a review from spawnia July 10, 2024 08:16
@@ -51,6 +51,7 @@ export function SelectField<
// Makes the allowClear method able to actually affect the form value
// See https://react-hook-form.com/api/usecontroller/controller
// > Calling onChange with undefined is not valid. You should use null or the empty string as your default/cleared value instead.
// @ts-expect-error error make no sense to me and i spent to much time on it
Copy link
Contributor Author

@Quis90 Quis90 Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier kommt der Fehler TOption | TOption[] ist nicht komptatibel mit (BaseOption | DefaultOption | (BaseOption | DefaultOption)[]), habe keine Ahnung wie ich den beheben soll hab ziemlich lange herumprobiert, hast du vllt ne Ahnung. Der Code funktioniert aufjedenfall der ref wird durchgereicht und auch sonst konnte ich keine abweichung feststellen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sollte gelöst sein. Bitte teste ob noch alles passt.

Copy link
Member

@spawnia spawnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge dann mit Squash und Commit-Message:

feat: add property `ref` to `SelectField` and `AutocompleteField`

@Quis90 Quis90 merged commit 965556e into master Jul 10, 2024
6 checks passed
@Quis90 Quis90 deleted the forward-ref-select-autocomplete-field branch July 10, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants