Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Commit

Permalink
Merge pull request #3 from mll-lab/change_plate_well_implementation
Browse files Browse the repository at this point in the history
delete getWells and change illuminate requirements
  • Loading branch information
simbig authored Nov 11, 2021
2 parents fc66683 + 4f56367 commit 7faebd2
Show file tree
Hide file tree
Showing 7 changed files with 3,198 additions and 4,929 deletions.
15 changes: 12 additions & 3 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ on:
push:
branches:
- master
schedule:
- cron: '0 0 * * *'

name: "Continuous Integration"

Expand Down Expand Up @@ -138,8 +140,6 @@ jobs:
run: vendor/bin/phpstan analyse --configuration=phpstan.neon

tests:
name: "Tests"

runs-on: ubuntu-latest

strategy:
Expand All @@ -150,9 +150,15 @@ jobs:

dependencies:
- lowest
- locked
- highest

illuminate:
- ^6
- ^7
- ^8

name: PHP ${{ matrix.php-version }} - Illuminate ${{ matrix.illuminate }} - ${{ matrix.dependencies }}

steps:
- name: "Checkout"
uses: actions/checkout@master
Expand All @@ -164,6 +170,9 @@ jobs:
extensions: mbstring
php-version: ${{ matrix.php-version }}

- name: "Install illuminate"
run: composer require "illuminate/support:${{ matrix.illuminate }}" --no-interaction --no-update

- name: "Install lowest dependencies with composer"
if: matrix.dependencies == 'lowest'
run: composer update --prefer-lowest --no-interaction --no-progress --no-suggest
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

## v2.0.0

### Add
- Add compatibility to Illuminate\Support `^6|^7|^8`

### Removed
- Removed method `getWells()` from class `MicroPlate` - use `wells` property of `MicroPlate` class

## v1.0.0

### Added
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ $wellContent2 = 'bar';
$microPlate->addWell($microPlateCoordinate2, $wellContent2);

// retrieve wells from plate
$microPlate->getWells()
$microPlate->wells
```


Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
],
"require": {
"php": "^7.4 || ^8",
"laravel/framework": "^7.30",
"illuminate/support": "^6 || ^7 || ^8",
"myclabs/php-enum": "^1.7",
"thecodingmachine/safe": "^1"
},
Expand Down
Loading

0 comments on commit 7faebd2

Please sign in to comment.